feat: tech-stack demo panels and shiki fix#26
Merged
Conversation
The tech-stack route needed stronger evidence of hands-on depth than a flat list of badges. This change adds a focused shiki-magic-move/react showcase for code-centric stacks and leaves Supabase as an explanation-first case where narrative communicates expertise better than a toy diff. Constraint: Keep the route mostly server-rendered with a narrow client boundary Constraint: Must preserve non-code stack cards without forcing showcase content everywhere Rejected: Make every stack a code diff | weak signal for tools and data platforms like Supabase Rejected: Use a generic code-only showcase for Supabase | narrative better reflects product/data judgment than a tiny snippet Confidence: high Scope-risk: moderate Directive: Keep showcase entries curated; do not add code diffs for stacks unless the comparison teaches a real implementation upgrade Tested: lsp_diagnostics on modified files; pnpm lint; pnpm test src/pages-layer/tech-stack/tech-stack-page.test.tsx; pnpm test:e2e tests/tech-stack.spec.ts --project='Desktop Chrome'; pnpm build Not-tested: Cross-browser Playwright coverage for the new Supabase narrative state
… / Next.js 16
- Add TechCategoryDemoPanel component reusing shiki-magic-move setup per category section
- Fix ShikiMagicMove animation bug by adding key={activeStack.name} to force remount per stack
- Refactor prefersReducedMotion to useSyncExternalStore
- Update React after-code to useActionState (React 19)
- Update Next.js after-code to PageProps<'/route'> global helper (Next.js 16 typegen)
- Update TypeScript after-code to discriminated union + satisfies operator
- Update Playwright after-code to test.step structured blocks
- Rewrite Supabase narrative to highlight RLS, real-time, and typed client strengths
- Update en/ko translations for all showcase items
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d7e51bd9bb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Use getAllByRole()[0] for unit tests and .first() for Playwright to handle duplicate React/Supabase buttons from showcase + category panels - Update React "after" assertion from useMutation to useActionState - Use getAllByText for narrative text that appears in both panels Addresses PR #26 review feedback. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
pnpm testfor unit testspnpm e2efor Playwright tests🤖 Generated with Claude Code