Addition of new template (ADHD) #52
Conversation
RileyCullen
left a comment
RileyCullen
left a comment
There was a problem hiding this comment.
Overall, good job. Most of the issues were formatting issues.
Make sure to check the statements where you create text elements so that the CSS matches the attributes in the call to SetCSSInfo. If these are inconsistent, then the text displayed in the Quill text editor will be different.
Also, use let instead of var.
| }); | ||
| } | ||
|
|
||
| _CreateSectionHeader(){ |
There was a problem hiding this comment.
Formatting: Brackets for functions should be on the next line (NOTE that the exception is when using arrow functions)
| let sideBarGroup = new Konva.Group(); | ||
| sectionHead.add(sideBarGroup) | ||
| let sideBarLeft = new RectangleHeader( | ||
| { |
There was a problem hiding this comment.
Formatting: Opening brackets should be on the same line as "new RectangleHeader" and closing brackets should be on same line as ");"
|
|
||
| this._main.add(sectionHead) | ||
|
|
||
| var roboto700 = this._quillMap('Roboto', 700); |
There was a problem hiding this comment.
Remove declaration, variable already defined
| }); | ||
| this._textHandler.SetCSSInfo({ | ||
| id: this._textHandler.GetCurrID(), | ||
| fontFamily: roboto700, |
There was a problem hiding this comment.
fontFamily not consistent with font weight used in sectionTitle
| fontSize: '55px', | ||
| textColor: sectionTitleDiv.style.color, | ||
| lineHeight: '1.2', | ||
| align: 'center', |
There was a problem hiding this comment.
lineHeight and center attributes defined here but not in the CSS for sectionTitle
|
|
||
| var waffleOneTextDiv = document.createElement('div') | ||
| var waffleOneText = '<p style="margin: 0px;"><span style="font-size: 20px; font-family: Roboto, sans-serif; font-weight: 400; line-height: 1.0;">' | ||
| + '8.4% of children ages 3-17 are</span></p>' |
There was a problem hiding this comment.
Formatting: Multi-line statements should be indented
| }); | ||
| sectionOne.add(waffleTwoGroup); | ||
|
|
||
| var BoysPreset = GenerateWafflePreset(ADHD, DARK_BLUE, DEFAULT_OFFSET, ICON_FONT), |
There was a problem hiding this comment.
Formatting: variable names should start lower case
Also, you should use let instead of var
Added a bar chart, waffle chart, images and the last line of text
|
|
||
| _CreateWaffleCharts() | ||
| { | ||
| let sectionOne = this._CreateSwitchableContainer( |
There was a problem hiding this comment.
Create groups using new Konva.Group() and not _CreateSwitchableContainer
| sectionOne.add(waffleOneGroup); | ||
|
|
||
| var ICON_FONT = '"Font Awesome 5 Free"'; | ||
| console.log("Default offset: " + DEFAULT_OFFSET); |
There was a problem hiding this comment.
Remove console.log debugging statements
| tickStrokeWidth: 0.5, | ||
| font: xAxisFont | ||
| }); | ||
| var valueDecoratorOne = new DataValueDecorator({ |
There was a problem hiding this comment.
Remove decorator creation call and addition to handler
No description provided.