Open
Conversation
Closed
rubenrouwhof
added a commit
that referenced
this pull request
Jan 7, 2026
- Add closedby='any' attribute to dialog for native ESC/backdrop closing - Create centralized dialog.js for auto-show functionality - Remove inline JavaScript from templates - Maintain HTMX compatibility for dynamic content loading - Simplify dialog implementation using more native browser features
rubenrouwhof
added a commit
that referenced
this pull request
Jan 7, 2026
- Update UserListView and label_admin views for URL-based modal triggers - Replace HTMX modal loading with server-side conditionals - Create user_form_fields.html and label form field templates - Update user_list.html and label_admin.html with dialog elements - Simplify view logic - just POST processing and redirects - Follow PR #116 pattern with closedby='any' and .close class
rubenrouwhof
added a commit
that referenced
this pull request
Jan 7, 2026
- Simplify dialog.js to only handle auto-show and close buttons - Remove all HTMX modal loading logic - Convert label_category.html to use URL links instead of HTMX - Update all label views to simple POST + redirect pattern - Fix label_create URL routing to remove pk parameter - Replace HTMX label forms with regular form submissions - Clean up all view functions to remove HTMX-specific code Now follows clean PR #116 pattern with server-side conditionals
rubenrouwhof
added a commit
that referenced
this pull request
Jan 7, 2026
- Remove redundant DOMContentLoaded listeners - Use .close selector instead of .modal-close (consistent with PR #116) - Only handle htmx:afterSwap events for dynamic content - Update generic_form_modal.html to use .close class - Cleaner hybrid HTMX + native dialog approach
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.