feat: add thread_id and local file support to proactive channel_send#510
Closed
houko wants to merge 10 commits intoRightNow-AI:mainfrom
Closed
feat: add thread_id and local file support to proactive channel_send#510houko wants to merge 10 commits intoRightNow-AI:mainfrom
houko wants to merge 10 commits intoRightNow-AI:mainfrom
Conversation
Contributor
Author
|
Follow-up pushed in This tightens the initial implementation in two ways:
Validation rerun on the PR branch:
Also re-verified live against a real Telegram topic on the PR branch code:
|
Contributor
Author
|
Follow-up pushed in This also fixes Telegram rendering for proactive outbound sends:
Validation:
|
Contributor
Author
|
Added two follow-up commits on top of the existing thread/topic work:
Validation rerun after these commits:
The |
This was referenced Mar 13, 2026
Closed
Member
|
Has merge conflicts with current main. Please rebase and resubmit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thread_idandfile_pathsupport to proactivechannel_sendsend_in_thread(...)whenthread_idis presentsendDocumentaccept an existing local file path and upload it via multipart while preservingmessage_thread_idfile_pathexplicitly telegram-only for now, with a clear runtime error on unsupported channelsWhy
Closes #509. OpenFang already supports threaded Telegram replies at the adapter level, but the proactive outbound path still could not target a specific thread/topic or send a generated local file without an external wrapper.
Validation
cargo test -p openfang-runtime test_channel_sendcargo test -p openfang-channels telegram::tests::test_api_send_document_multipart_for_local_file_preserves_thread_idcargo test -p openfang-channels telegram::tests::test_parse_telegram_document_fallbackcargo test -p openfang-channels telegram::tests::test_local_document_path_accepts_existing_file_and_file_schemecargo check -p openfang-kernel18using the PR branch code