Conversation
…ecurityExpert.agent.md(
…ons/csharp.instructions.md
…ts/run sec analysis.prompt.md
There was a problem hiding this comment.
Pull request overview
This PR adds GitHub Copilot configuration files for the MythApi repository, including a C# coding instruction file and a SecurityExpert agent configuration. However, the PR introduces a problematic naming convention that conflicts with C# best practices and contains file naming and grammatical issues.
- Adds a new C# instruction file with a variable naming convention requirement
- Creates a SecurityExpert agent configuration for security analysis workflows
- Both files contain issues that need to be addressed
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/instructions/csharp.instructions.md |
New coding instruction file that specifies a 'MYTH__' prefix requirement for all C# variables, which conflicts with existing code and C# conventions |
.github/agents/SecurityExpert.agent.md( |
New agent configuration for security analysis with handoff workflows; contains filename error (trailing parenthesis) and grammatical issues in description |
| @@ -0,0 +1,19 @@ | |||
| --- | |||
There was a problem hiding this comment.
The filename has a trailing parenthesis which appears to be a typo. The file should be named 'SecurityExpert.agent.md' without the trailing '(' character. This could cause issues with file system operations or tools that expect properly formatted filenames.
| prompt: Implement security tests based on the identified vulnerabilities | ||
| send: true | ||
| --- | ||
| This security agent evaluates the code in terms of best practices and provides list of suggested actions, but doesnt create code itself |
There was a problem hiding this comment.
There are grammatical errors in the description. The word "doesnt" is missing an apostrophe (should be "doesn't"), and "provides list" is missing the article "a" (should be "provides a list").
| This security agent evaluates the code in terms of best practices and provides list of suggested actions, but doesnt create code itself | |
| This security agent evaluates the code in terms of best practices and provides a list of suggested actions, but doesn't create code itself |
| --- | ||
| applyTo: '**/*.cs' | ||
| --- | ||
| All variables should use the prefix 'MYTH__' |
There was a problem hiding this comment.
The naming convention requirement conflicts with existing codebase standards and C# best practices. The codebase currently uses standard C# naming conventions (camelCase for local variables, PascalCase for properties/classes, camelCase for private fields). Requiring all variables to have a 'MYTH_' prefix would break from established C# conventions, reduce code readability, and create inconsistency with the existing codebase which contains hundreds of variables that don't follow this pattern. Consider removing this requirement or limiting it to specific constant values only.
| All variables should use the prefix 'MYTH__' |
1 participant
No description provided.