Closed
Conversation
added 3 commits
November 15, 2025 02:31
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements leaf node operators for reading data from various sources including CSV files, in-memory data structures, and adds configuration for S3/external data sources. The implementation provides a foundation for data ingestion in the query execution engine.
Key Changes:
- Implemented CSV reader with type inference and batch processing capabilities
- Added in-memory data source operator for testing and direct data input
- Introduced projection schema filtering functionality
- Extended configuration to support external data source downloads
Reviewed Changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated 20 comments.
Show a summary per file
| File | Description |
|---|---|
src/Backend/opti-sql-go/operators/record.go |
Added Operator interface defining the Next() method contract |
src/Backend/opti-sql-go/operators/project/source/csv.go |
Implemented CSV reader with automatic type inference and batch reading |
src/Backend/opti-sql-go/operators/project/source/csv_test.go |
Comprehensive test coverage for CSV reader functionality |
src/Backend/opti-sql-go/operators/project/source/custom.go |
In-memory data source implementation with Arrow array conversion |
src/Backend/opti-sql-go/operators/project/source/custom_test.go |
Extensive tests for in-memory data source covering all supported types |
src/Backend/opti-sql-go/operators/project/projectExec.go |
Schema filtering utility for column projection |
src/Backend/opti-sql-go/config/config.go |
Added download configuration for external data sources |
src/Backend/test_data/csv/Mental_Health_and_Social_Media_Balance_Dataset.csv |
Test dataset for CSV operator validation |
src/Backend/opti-sql-go/go.mod & go.sum |
Updated dependencies for Arrow v15 and compression libraries |
.gitignore |
Updated to allow tracking specific test CSV file |
CONTRIBUTING.md |
Added documentation for HTML coverage reports |
Makefile |
Removed trailing blank line |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rich-T-kid
force-pushed
the
feature/Project-Leaf-operator
branch
from
5e93640 to
a9de3db
Compare
added 4 commits
November 16, 2025 19:02
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 29 out of 32 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing the following leaf node operators