feat(GRPC-spec): define grpc contract between Query parser and query …#7
Merged
Rich-T-kid merged 11 commits intomainfrom Nov 14, 2025
Merged
feat(GRPC-spec): define grpc contract between Query parser and query …#7Rich-T-kid merged 11 commits intomainfrom
Rich-T-kid merged 11 commits intomainfrom
Conversation
…execution enginee
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR defines a gRPC contract between the Query parser and query execution engine, establishing the communication protocol for executing SQL queries with Substrait logical plans.
- Adds gRPC service definition with request/response messages for query execution
- Includes test data structure for S3 source files
- Updates documentation to reflect removed sections and clarify prerequisites
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| src/Contract/operation.proto | New gRPC service definition for query execution with Substrait logical plans, including request/response messages, error handling enums, and data flow documentation |
| src/Backend/test_data/s3_source/source.json | Test data structure showing example S3 file paths for CSV, JSON, and Parquet formats |
| README.md | Updated prerequisites with C++ version, removed outdated project directory description, and cleaned up license section formatting |
| .gitignore | Added exclusions for large test data files (parquet, csv, json) while explicitly allowing the s3_source directory |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
… (supporting test included)
Rich-T-kid
force-pushed
the
pre-release
branch
from
72697c6 to
5d8357f
Compare
Owner
Author
|
provide a class for dealing with writing record batches to file(s) and reading them back in in chunks and then repeating this proccess. Will be very useful for pipeline breakers down the line. Then once thats done merge into main before starting on operators like (Project, filter, limit) |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 10 out of 12 changed files in this pull request and generated 12 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 27 out of 29 changed files in this pull request and generated 10 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rich-T-kid
force-pushed
the
pre-release
branch
2 times, most recently
from
cde64d0 to
1dce3d4
Compare
Rich-T-kid
force-pushed
the
pre-release
branch
from
1dce3d4 to
6b744fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…execution enginee