-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/expresion operator #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
bec1b3b
feat(ProjectExecCSV) Implement csv reader that transforms csv file in…
334c0c5
feat:InmemoryProject Operator.this provide a base for easy mock testi…
7159b86
removed json as datasource
a9de3db
feature:ParquetSource operator is implemented
98b55f3
feat: Implement s3 file reader & file downloader
6ee5178
feat:Implement Project operator | tested on top source operators
e7e9d82
chore: add next steps. Looking at Expr and Filter operators
f97e73b
chore: add next steps. Looking at Expr and Filter operators
86b1e3c
fix:revised PR
667294a
Merge pull request #9 from Rich-T-kid/feature/Project-Leaf-operator
Rich-T-kid ee7d4a2
define Expr Interface & Expr Operators
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,105 @@ | ||
| package Expr | ||
|
|
||
| // evaluate expressions | ||
| // for example Column + Literal | ||
| // Column - Column | ||
| // Literal / Literal | ||
| import "github.com/apache/arrow/go/v17/arrow" | ||
|
|
||
| type binaryOperator int | ||
|
|
||
| const ( | ||
| // arithmetic | ||
| addition binaryOperator = 1 | ||
| subtraction binaryOperator = 2 | ||
| multiplication binaryOperator = 3 | ||
| division binaryOperator = 4 | ||
| modulous binaryOperator = 5 | ||
| // comparison | ||
| equal binaryOperator = 6 | ||
| notEqual binaryOperator = 7 | ||
| lessThan binaryOperator = 8 | ||
| lessThanOrEqual binaryOperator = 9 | ||
| greaterThan binaryOperator = 10 | ||
| greaterThanOrEqual binaryOperator = 11 | ||
| // logical | ||
| and binaryOperator = 12 | ||
| or binaryOperator = 13 | ||
| not binaryOperator = 14 | ||
| ) | ||
|
|
||
| type supportedFunctions int | ||
|
|
||
| const ( | ||
| upper supportedFunctions = 1 | ||
| lower supportedFunctions = 2 | ||
| abs supportedFunctions = 3 | ||
| round supportedFunctions = 4 | ||
| ) | ||
|
|
||
| type aggFunctions = int | ||
|
|
||
| const ( | ||
| Sum aggFunctions = 1 | ||
| Count aggFunctions = 2 | ||
| Avg aggFunctions = 3 | ||
| Min aggFunctions = 4 | ||
| Max aggFunctions = 5 | ||
| ) | ||
|
|
||
| /* | ||
| Eval(expr): | ||
|
|
||
| match expr: | ||
| Literal(x) -> return x | ||
| Column(name) -> return array of that column | ||
| BinaryExpr(left > right) -> eval left, eval right, apply operator | ||
| ScalarFunction(upper(name)) -> evaluate function | ||
| Alias(expr, name) -> just a name wrapper | ||
| */ | ||
| type Expr interface { | ||
| ExprNode() // empty method, only for the sake of polymophism | ||
| } | ||
|
|
||
| /* | ||
| Alias | sql: select col1 as new_name from table_source | ||
| updates the column name in the output schema. | ||
| */ | ||
| type Alias struct { | ||
| expr []Expr | ||
| columnName string | ||
| name string | ||
| } | ||
|
|
||
| // return batch.Columns[fieldIndex["age"]] | ||
| // resolves the arrow array corresponding to name passed in | ||
| // sql: select age | ||
| type ColumnResolve struct { | ||
| name string | ||
| } | ||
|
|
||
| // Evaluates to a column of length = batch-size, filled with this literal. | ||
| // sql: select 1 | ||
| type LiteralResolve struct { | ||
| Type arrow.DataType | ||
| value any | ||
| } | ||
|
|
||
| type Operator struct { | ||
| o binaryOperator | ||
| } | ||
| type BinaryExpr struct { | ||
| left []Expr | ||
| op Operator | ||
| right []Expr | ||
| } | ||
|
|
||
| type ScalarFunction struct { | ||
| function supportedFunctions | ||
| input []Expr // resolve to something you can procees IE, literal/coloumn Resolve | ||
| } | ||
| type AggregateFunction struct { | ||
| function aggFunctions | ||
| args []Expr | ||
| } | ||
|
|
||
| type CastExpr struct { | ||
| expr []Expr // can be a Literal or Column (check for datatype then) | ||
| targetType arrow.DataType | ||
| } |
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,7 +1,24 @@ | ||||||
| package filter | ||||||
|
|
||||||
| // handle Bitwise operations here as well | ||||||
| import ( | ||||||
| "github.com/apache/arrow/go/v17/arrow" | ||||||
| "github.com/apache/arrow/go/v17/arrow/array" | ||||||
| ) | ||||||
|
|
||||||
| // OR | ||||||
| // AND | ||||||
| // NOT | ||||||
| // FilterExpr takes in a field and column and yeilds a function that takes in an index and returns a bool indicating whether the row at that index satisfies the filter condition. | ||||||
|
||||||
| // FilterExpr takes in a field and column and yeilds a function that takes in an index and returns a bool indicating whether the row at that index satisfies the filter condition. | |
| // FilterExpr takes in a field and column and yields a function that takes in an index and returns a bool indicating whether the row at that index satisfies the filter condition. |
Copilot
AI
Nov 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in parameter name: 'filed' should be 'field'.
Suggested change
| type FilterExpr func(filed arrow.Field, col arrow.Array) func(i int) bool | |
| type FilterExpr func(field arrow.Field, col arrow.Array) func(i int) bool |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoded AWS/S3 credentials (Access Key and Secret Key) are exposed in the codebase. These sensitive credentials should never be committed to version control. Use environment variables or a secure secrets management system instead.