Skip to content

fix CMake build with RNP#275

Open
dbear496 wants to merge 3 commits intoRetroShare:masterfrom
dbear496:fix-cmake-with-rnp
Open

fix CMake build with RNP#275
dbear496 wants to merge 3 commits intoRetroShare:masterfrom
dbear496:fix-cmake-with-rnp

Conversation

@dbear496
Copy link
Copy Markdown
Contributor

Fixes CMake builds when using librnp.

@csoler
Copy link
Copy Markdown
Contributor

csoler commented Mar 29, 2026

I would be better to have RNP as the default and openpgp-sdk as an option, since RS has officially switched to rnp now.

@G10h4ck
Copy link
Copy Markdown
Contributor

G10h4ck commented Mar 31, 2026

@csoler @dbear496 to make it default just add a block like this ( in alphabetical order) in topdir CMakeLists.txt

option(
	RS_RNPLIB
	"Use RNP for PGP operations"
	ON )

@dbear496
Copy link
Copy Markdown
Contributor Author

Okay, I defined the RS_RNPLIB option in libretroshare with the default ON. However, just a heads up that the default for RS_RNPLIB in retroshare-service is still OFF, so building retroshare-service will still default to not use rnp.

@G10h4ck
Copy link
Copy Markdown
Contributor

G10h4ck commented Mar 31, 2026

@dbear496 please fix retroshare-service too

@dbear496
Copy link
Copy Markdown
Contributor Author

dbear496 commented Apr 1, 2026

retroshare-service is not part of this repository.

@G10h4ck
Copy link
Copy Markdown
Contributor

G10h4ck commented Apr 1, 2026

@dbear496 yes, please open a PR on that repository too. @csoler anything else to change before merging?

@csoler
Copy link
Copy Markdown
Contributor

csoler commented Apr 1, 2026

Does RS_RNP_LIB also works as a preprocessor variable (question from a non cmake user) ? RS needs one to include the proper files.

@dbear496
Copy link
Copy Markdown
Contributor Author

dbear496 commented Apr 1, 2026

@csoler , that's a good catch. I added the USE_OPENPGPSDK define in CMake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants