Open
Conversation
Contributor
|
I would be better to have RNP as the default and openpgp-sdk as an option, since RS has officially switched to rnp now. |
Contributor
Contributor
Author
|
Okay, I defined the |
Contributor
|
@dbear496 please fix retroshare-service too |
Contributor
Author
|
retroshare-service is not part of this repository. |
Contributor
Contributor
|
Does RS_RNP_LIB also works as a preprocessor variable (question from a non cmake user) ? RS needs one to include the proper files. |
Contributor
Author
|
@csoler , that's a good catch. I added the USE_OPENPGPSDK define in CMake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CMake builds when using librnp.