Skip to content

Conversation

@Wolf2323
Copy link


  • The main commit(s) reference the Fibery ticket via a TASK-NNNN prefix in the commit message subject
  • Include a human-readable description of what the pull request is trying to accomplish
  • The CI build passes

  • New automated tests have been added
  • The changes are already covered by automated tests and have been adapted
  • These manual test cases cover this change:
  • Steps for the reviewer(s) on how they can manually QA the changes:
  • This is a minor internal change; basic CI/CD coverage is enough
  • This is an incomplete feature hidden behind feature flag:
  • This is proof-of-concept / experimental code not for production / marked @Deprecated
  • No (significant) changes to production code

  • Classes and public methods have documentation (that doesn't just repeat the technical subject in English)
  • Logging is implemented to monitor feature usage and troubleshoot problems in production
  • These ReWiki pages are affected by this change and will be adapted:

  • The change is unrelated to Minecraft
  • Works in Java edition
  • Works in Bedrock edition

@Wolf2323 Wolf2323 enabled auto-merge December 18, 2024 10:51
@Wolf2323 Wolf2323 merged commit 1788457 into main Dec 18, 2024
2 checks passed
@Wolf2323 Wolf2323 deleted the fixNPE branch December 18, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants