[Fix] event creation

TickAPI/TickAPI.Tests/Events/Services/EventServiceTests.cs

@@ -105,7 +105,7 @@ public async Task CreateNewEventAsync_WhenEventDataIsValid_ShouldReturnNewEvent(
         dateTimeServiceMock.Setup(m => m.GetCurrentDateTime()).Returns(new DateTime(2003, 7, 11));
 
         var categoryServiceMock = new Mock<ICategoryService>();
-        categoryServiceMock.Setup(c => c.CheckIfCategoriesExistAsync(It.IsAny<List<Category>>())).Returns(Task.FromResult(true));
+        categoryServiceMock.Setup(c => c.GetCategoriesByNames(It.IsAny<List<string>>())).Returns(Result<List<Category>>.Success(expectedCategories));
 
         var paginationServiceMock = new Mock<IPaginationService>();
 

TickAPI/TickAPI/Addresses/Models/Address.cs

@@ -8,5 +8,4 @@ public class Address
     public uint? HouseNumber { get; set; }
     public uint? FlatNumber { get; set; }
     public string PostalCode { get; set; }
-
 }

TickAPI/TickAPI/Categories/Abstractions/ICategoryRepository.cs

@@ -7,5 +7,6 @@ public interface ICategoryRepository
 {
     public IQueryable<Category> GetCategories();
     public Task<Result<Category>> GetCategoryByNameAsync(string categoryName);
+    public Result<IQueryable<Category>> GetCategoriesByNames(IEnumerable<string> categoryNames);
     public Task AddNewCategoryAsync(Category category);
 }

TickAPI/TickAPI/Categories/Abstractions/ICategoryService.cs

@@ -10,6 +10,5 @@ public interface ICategoryService
     public Task<Result<Category>> GetCategoryByNameAsync(string categoryName);
     public Task<Result<PaginatedData<GetCategoryResponseDto>>> GetCategoriesResponsesAsync(int pageSize, int page);
     public Task<Result<Category>> CreateNewCategoryAsync(string categoryName);
-
-    public Task<bool> CheckIfCategoriesExistAsync(IEnumerable<Category> categories);
+    public Result<List<Category>> GetCategoriesByNames(IList<string> categoryNames);
 }

TickAPI/TickAPI/Categories/Respositories/CategoryRepository.cs

@@ -1,6 +1,7 @@
 using Microsoft.EntityFrameworkCore;
 using TickAPI.Categories.Abstractions;
 using TickAPI.Categories.Models;
+using TickAPI.Common.Results;
 using TickAPI.Common.Results.Generic;
 using TickAPI.Common.TickApiDbContext;
 namespace TickAPI.Categories.Respositories;
@@ -31,6 +32,18 @@ public async Task<Result<Category>> GetCategoryByNameAsync(string categoryName)
         return Result<Category>.Success(category);
     }
 
+    public Result<IQueryable<Category>> GetCategoriesByNames(IEnumerable<string> categoryNames)
+    {
+        var categories = _tickApiDbContext.Categories.Where(c => categoryNames.Contains(c.Name));
+
+        if (categories.Count() < categoryNames.Count())
+        {
+            return Result<IQueryable<Category>>.Failure(StatusCodes.Status404NotFound, "one or more of category names is invalid");
+        }
+
+        return Result<IQueryable<Category>>.Success(categories);
+    }
+
     public async Task AddNewCategoryAsync(Category category)
     {
         _tickApiDbContext.Categories.Add(category);

TickAPI/TickAPI/Categories/Services/CategoryService.cs

@@ -5,6 +5,7 @@
 using TickAPI.Common.Pagination.Abstractions;
 using TickAPI.Common.Pagination.Responses;
 using TickAPI.Common.Results.Generic;
+using TickAPI.Events.Models;
 
 namespace TickAPI.Categories.Services;
 
@@ -56,11 +57,16 @@ public async Task<Result<Category>> CreateNewCategoryAsync(string categoryName)
         await _categoryRepository.AddNewCategoryAsync(category);
         return Result<Category>.Success(category);
     }
-    
-    public async Task<bool> CheckIfCategoriesExistAsync(IEnumerable<Category> categories)
+
+    public Result<List<Category>> GetCategoriesByNames(IList<string> categoryNames)
     {
-        var dbCategories = _categoryRepository.GetCategories();
-        int count = await dbCategories.Where(cdb => categories.Any(c => c.Name == cdb.Name)).CountAsync();
-        return count == categories.Count();
+        var result = _categoryRepository.GetCategoriesByNames(categoryNames);
+
+        if (result.IsError)
+        {
+            return Result<List<Category>>.PropagateError(result);
+        }
+
+        return Result<List<Category>>.Success(result.Value!.ToList());
     }
 }

TickAPI/TickAPI/Events/Repositories/EventRepository.cs

@@ -8,13 +8,13 @@ namespace TickAPI.Events.Repositories;
 
 public class EventRepository : IEventRepository
 {
-
     private readonly TickApiDbContext _tickApiDbContext;
 
     public EventRepository(TickApiDbContext tickApiDbContext)
     {
         _tickApiDbContext = tickApiDbContext;
     }
+
     public async Task AddNewEventAsync(Event @event)
     {
         _tickApiDbContext.Events.Add(@event);

TickAPI/TickAPI/Events/Services/EventService.cs

@@ -4,7 +4,6 @@
 using TickAPI.Common.Pagination.Responses;
 using TickAPI.Categories.Abstractions;
 using TickAPI.Categories.DTOs.Request;
-using TickAPI.Categories.Models;
 using TickAPI.Common.Time.Abstractions;
 using TickAPI.Events.Abstractions;
 using TickAPI.Events.Models;
@@ -61,12 +60,13 @@ public async Task<Result<Event>> CreateNewEventAsync(string name, string  descri
 
         var address = await _addressService.GetOrCreateAddressAsync(createAddress);
 
-        var categoriesConverted = categories.Select(c => new Category { Name = c.CategoryName }).ToList();
+        var categoryNames = categories.Select(c => c.CategoryName).ToList();
 
-        var categoriesExist = await _categoryService.CheckIfCategoriesExistAsync(categoriesConverted);
-        if (!categoriesExist)
+        var categoriesByNameResult = _categoryService.GetCategoriesByNames(categoryNames);
+
+        if (categoriesByNameResult.IsError)
         {
-            return Result<Event>.Failure(StatusCodes.Status400BadRequest, "Category does not exist");
+            return Result<Event>.PropagateError(categoriesByNameResult);
         }
 
         var ticketTypesConverted = ticketTypes.Select(t => new TicketType
@@ -87,7 +87,7 @@ public async Task<Result<Event>> CreateNewEventAsync(string name, string  descri
             EndDate = endDate,
             MinimumAge = minimumAge,
             Address = address.Value!,
-            Categories = categoriesConverted,
+            Categories = categoriesByNameResult.Value!,
             Organizer = organizerResult.Value!,
             EventStatus = eventStatus,
             TicketTypes = ticketTypesConverted,