Skip to content

Conversation

@kubapoke
Copy link
Member

Created a pipeline allowing for getting information about a specific event, including its ticket types from the front end application as a setup for creation of the shopping cart

@kubapoke kubapoke changed the base branch from main to develop April 27, 2025 15:04
DateTime StartDate,
DateTime EndDate,
uint? MinimumAge,
List<GetEventResponseCategoryDto> Categories,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we mix DTOs from GetEvent andGetEventDetails. I dont say it is wrong but shouldn't we create a GetEventDetailsResponseCategoryDto? I know it will be the same think but it looks like something that you would comment me on. It is more a question.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can stay this way? The thing is, usually we want to separate DTOs, even with the same content, for the possibility that one of them will need to change (which is especially important in request DTOs as we usually want to change parameters of one endpoint at a time). Here, I can't really think of a case, where we would want to have these DTOs differ (unless we add some parameter categories, which should be obstructed only in the "non-details" view, which I don't think is likely? But I'll leave the final judgement up to you, as maybe it would be more clear if these were separate records.

@staszkiet staszkiet merged commit 664d81f into develop Apr 27, 2025
1 check passed
@kubapoke kubapoke deleted the feat/event-pipeline branch April 27, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants