Feat/get categories #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kTrzcinskii
reviewed
Mar 31, 2025
| _tickApiDbContext = tickApiDbContext; | ||
| } | ||
|
|
||
| public async Task<Result<ICollection<Category>>> GetCategoriesAsync() |
Member
There was a problem hiding this comment.
If there is no possibility of an error we don't need to use Result<...>
Member
Author
There was a problem hiding this comment.
Isn't it better to stick to the convention?
Member
There was a problem hiding this comment.
I mean, the point of this class is to help us handle errors (we use it instead of exceptions). If we have no errors in the function using Result just makes things less readable imo.
kTrzcinskii
reviewed
Apr 3, 2025
staszkiet
force-pushed
the
feat/GetCategories
branch
from
113350c to
afc34c7
Compare
kubapoke
approved these changes
Apr 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.