Feat/add event #50
Merged
Feat/add event #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kTrzcinskii
reviewed
Mar 26, 2025
kubapoke
reviewed
Mar 28, 2025
| Assert.Equal(id, result.Value!.Id); | ||
| Assert.Equal(organizerEmail, result.Value!.Organizer.Email); | ||
| } | ||
| } No newline at end of file |
Member
There was a problem hiding this comment.
This lacks tests for the checks that you've specifically implemented (checking whether the start/end dates are in the future), so I think you should add these tests
| Assert.Equal("Event created succesfully", objectResult.Value); | ||
|
|
||
| } | ||
| } No newline at end of file |
Member
There was a problem hiding this comment.
You should probably add a test for checking whether the email claim isn't missing. It's present in other controller tests
kubapoke
approved these changes
Mar 29, 2025
Member
kubapoke
left a comment
kubapoke
left a comment
There was a problem hiding this comment.
I think everything seems good now, good job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.