Develop

TickAPI/TickAPI.Tests/Categories/Controllers/CategoriesControllerTests.cs

@@ -32,7 +32,7 @@ public async Task GetCategories_WhenDataIsValid_ShouldReturnOk()
 
         // Assert
         var result = Assert.IsType<ActionResult<PaginatedData<GetCategoryResponseDto>>>(res);
-        var objectResult = Assert.IsType<OkObjectResult>(result.Result);
+        var objectResult = Assert.IsType<ObjectResult>(result.Result);
         Assert.Equal(200, objectResult.StatusCode);
         Assert.NotNull(objectResult.Value);
     }

TickAPI/TickAPI.Tests/Common/Results/Generic/ResultTests.cs

@@ -1,4 +1,6 @@
-using TickAPI.Common.Results;
+using Microsoft.AspNetCore.Http;
+using Microsoft.AspNetCore.Mvc;
+using TickAPI.Common.Results;
 using TickAPI.Common.Results.Generic;
 
 namespace TickAPI.Tests.Common.Results.Generic;
@@ -8,10 +10,13 @@ public class ResultTests
     [Fact]
     public void Success_ShouldReturnResultWithValue()
     {
+        // Arrange
         const int value = 123;
 
+        // Act
         var result = Result<int>.Success(value);
 
+        // Assert
         Assert.Equal(value, result.Value);
         Assert.True(result.IsSuccess);
         Assert.False(result.IsError);
@@ -22,11 +27,14 @@ public void Success_ShouldReturnResultWithValue()
     [Fact]
     public void Failure_ShouldReturnResultWithError()
     {
+        // Arrange
         const int statusCode = 500;
         const string errorMsg = "example error msg";
 
+        // Act
         var result = Result<int>.Failure(500, errorMsg);
 
+        // Assert
         Assert.True(result.IsError);
         Assert.False(result.IsSuccess);
         Assert.Equal(errorMsg, result.ErrorMsg);
@@ -36,12 +44,15 @@ public void Failure_ShouldReturnResultWithError()
     [Fact]
     public void PropagateError_WhenResultWithErrorPassed_ShouldReturnResultWithError()
     {
+        // Arrange
         const int statusCode = 500;
         const string errorMsg = "error message";
         var resultWithError = Result<string>.Failure(statusCode, errorMsg);
 
+        // Act
         var result = Result<int>.PropagateError(resultWithError);
 
+        // Assert
         Assert.True(result.IsError);
         Assert.False(result.IsSuccess);
         Assert.Equal(errorMsg, result.ErrorMsg);
@@ -51,12 +62,15 @@ public void PropagateError_WhenResultWithErrorPassed_ShouldReturnResultWithError
     [Fact]
     public void PropagateError_WhenNonGenericResultWithErrorPassed_ShouldReturnResultWithError()
     {
+        // Arrange
         const int statusCode = 500;
         const string errorMsg = "error message";
         var resultWithError = Result.Failure(statusCode, errorMsg);
 
+        // Act
         var result = Result<int>.PropagateError(resultWithError);
 
+        // Assert
         Assert.True(result.IsError);
         Assert.False(result.IsSuccess);
         Assert.Equal(errorMsg, result.ErrorMsg);
@@ -66,20 +80,91 @@ public void PropagateError_WhenNonGenericResultWithErrorPassed_ShouldReturnResul
     [Fact]
     public void PropagateError_WhenResultWithSuccessPassed_ShouldThrowArgumentException()
     {
+        // Arrange
         var resultWithSuccess = Result<string>.Success("abc");
 
+        // Act
         var act = () => Result<int>.PropagateError(resultWithSuccess);
 
+        // Assert
         Assert.Throws<ArgumentException>(act);
     }
 
     [Fact]
     public void PropagateError_WhenNonGenericResultWithSuccessPassed_ShouldThrowArgumentException()
     {
+        // Arrange
         var resultWithSuccess = Result.Success();
 
+        // Act
         var act = () => Result<int>.PropagateError(resultWithSuccess);
 
+        // Assert
         Assert.Throws<ArgumentException>(act);
     }
+
+    [Fact]
+    public void ToObjectResult_WhenGenericResultIsError_ShouldReturnObjectResultWithErrorDetails()
+    {
+        // Arrange
+        const int statusCode = 404;
+        const string errorMsg = "Not found";
+        var result = Result<int>.Failure(statusCode, errorMsg);
+
+        // Act
+        var objectResult = result.ToObjectResult();
+
+        // Assert
+        Assert.IsType<ObjectResult>(objectResult);
+        Assert.Equal(statusCode, objectResult.StatusCode);
+        Assert.Equal(errorMsg, objectResult.Value);
+    }
+
+    [Fact]
+    public void ToObjectResult_WhenGenericResultIsSuccess_ShouldReturnObjectResultWithDefaultSuccessCode()
+    {
+        // Arrange
+        const int value = 42;
+        var result = Result<int>.Success(value);
+
+        // Act
+        var objectResult = result.ToObjectResult();
+
+        // Assert
+        Assert.IsType<ObjectResult>(objectResult);
+        Assert.Equal(StatusCodes.Status200OK, objectResult.StatusCode);
+        Assert.Equal(value, objectResult.Value);
+    }
+
+    [Fact]
+    public void ToObjectResult_WhenGenericResultIsSuccessWithCustomStatusCode_ShouldReturnObjectResultWithSpecifiedCode()
+    {
+        // Arrange
+        const string value = "Success data";
+        var result = Result<string>.Success(value);
+        const int customSuccessCode = StatusCodes.Status201Created;
+
+        // Act
+        var objectResult = result.ToObjectResult(customSuccessCode);
+
+        // Assert
+        Assert.IsType<ObjectResult>(objectResult);
+        Assert.Equal(customSuccessCode, objectResult.StatusCode);
+        Assert.Equal(value, objectResult.Value);
+    }
+
+    [Fact]
+    public void ToObjectResult_WhenGenericResultWithNullValueIsSuccess_ShouldReturnObjectResultWithNullValue()
+    {
+        // Arrange
+        var result = Result<string>.Success(null);
+
+        // Act
+        var objectResult = result.ToObjectResult();
+
+        // Assert
+        Assert.IsType<ObjectResult>(objectResult);
+        Assert.Equal(StatusCodes.Status200OK, objectResult.StatusCode);
+        Assert.Null(objectResult.Value);
+    }
 }

TickAPI/TickAPI.Tests/Common/Results/ResultTests.cs

@@ -1,4 +1,6 @@
-using TickAPI.Common.Results;
+using Microsoft.AspNetCore.Http;
+using Microsoft.AspNetCore.Mvc;
+using TickAPI.Common.Results;
 using TickAPI.Common.Results.Generic;
 
 namespace TickAPI.Tests.Common.Results;
@@ -8,8 +10,10 @@ public class ResultTests
     [Fact]
     public void Success_ShouldReturnResultWithSuccess()
     {
+        // Act
         var result = Result.Success();
 
+        // Assert
         Assert.True(result.IsSuccess);
         Assert.False(result.IsError);
         Assert.Equal("", result.ErrorMsg);
@@ -19,11 +23,29 @@ public void Success_ShouldReturnResultWithSuccess()
     [Fact]
     public void Failure_ShouldReturnResultWithError()
     {
+        // Arrange
         const int statusCode = 500;
         const string errorMsg = "example error msg";
 
+        // Act
         var result = Result.Failure(500, errorMsg);
 
+        // Assert
+        Assert.True(result.IsError);
+        Assert.False(result.IsSuccess);
+        Assert.Equal(errorMsg, result.ErrorMsg);
+        Assert.Equal(statusCode, result.StatusCode);
+    }
+
+    [Fact]
+    public void PropagateError_WhenResultWithErrorPassed_ShouldReturnResultWithError()
+    {
+        const int statusCode = 500;
+        const string errorMsg = "error message";
+        var resultWithError = Result.Failure(statusCode, errorMsg);
+
+        var result = Result.PropagateError(resultWithError);
+
         Assert.True(result.IsError);
         Assert.False(result.IsSuccess);
         Assert.Equal(errorMsg, result.ErrorMsg);
@@ -33,25 +55,89 @@ public void Failure_ShouldReturnResultWithError()
     [Fact]
     public void PropagateError_WhenGenericResultWithErrorPassed_ShouldReturnResultWithError()
     {
+        // Arrange
         const int statusCode = 500;
         const string errorMsg = "error message";
         var resultWithError = Result<int>.Failure(statusCode, errorMsg);
 
+        // Act
         var result = Result.PropagateError(resultWithError);
 
+        // Assert
         Assert.True(result.IsError);
         Assert.False(result.IsSuccess);
         Assert.Equal(errorMsg, result.ErrorMsg);
         Assert.Equal(statusCode, result.StatusCode);
     }
 
+    [Fact]
+    public void PropagateError_WhenResultWithSuccessPassed_ShouldThrowArgumentException()
+    {
+        var resultWithSuccess = Result.Success();
+
+        var act = () => Result.PropagateError(resultWithSuccess);
+
+        Assert.Throws<ArgumentException>(act);
+    }
+
     [Fact]
     public void PropagateError_WhenGenericResultWithSuccessPassed_ShouldThrowArgumentException()
     {
+        // Arrange
         var resultWithSuccess = Result<int>.Success(123);
 
+        // Act
         var act = () => Result<int>.PropagateError(resultWithSuccess);
 
+        // Assert
         Assert.Throws<ArgumentException>(act);
     }
+
+    [Fact]
+    public void ToObjectResult_WhenResultIsError_ShouldReturnObjectResultWithErrorDetails()
+    {
+        // Arrange
+        const int statusCode = 400;
+        const string errorMsg = "Bad request";
+        var result = Result.Failure(statusCode, errorMsg);
+
+        // Act
+        var objectResult = result.ToObjectResult();
+
+        // Assert
+        Assert.IsType<ObjectResult>(objectResult);
+        Assert.Equal(statusCode, objectResult.StatusCode);
+        Assert.Equal(errorMsg, objectResult.Value);
+    }
+
+    [Fact]
+    public void ToObjectResult_WhenResultIsSuccess_ShouldReturnObjectResultWithDefaultSuccessCode()
+    {
+        // Arrange
+        var result = Result.Success();
+
+        // Act
+        var objectResult = result.ToObjectResult();
+
+        // Assert
+        Assert.IsType<ObjectResult>(objectResult);
+        Assert.Equal(StatusCodes.Status200OK, objectResult.StatusCode);
+        Assert.Equal(string.Empty, objectResult.Value);
+    }
+
+    [Fact]
+    public void ToObjectResult_WhenResultIsSuccessWithCustomStatusCode_ShouldReturnObjectResultWithSpecifiedCode()
+    {
+        // Arrange
+        var result = Result.Success();
+        const int customSuccessCode = StatusCodes.Status201Created;
+
+        // Act
+        var objectResult = result.ToObjectResult(customSuccessCode);
+
+        // Assert
+        Assert.IsType<ObjectResult>(objectResult);
+        Assert.Equal(customSuccessCode, objectResult.StatusCode);
+        Assert.Equal(string.Empty, objectResult.Value);
+    }
 }

TickAPI/TickAPI.Tests/Events/Controllers/EventsControllerTests.cs

@@ -20,7 +20,7 @@ namespace TickAPI.Tests.Events.Controllers;
 
 public class EventsControllerTests
 {
-    private readonly EventFiltersDto _emptyFilters = new EventFiltersDto(null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null);
+    private readonly EventFiltersDto _emptyFilters = new EventFiltersDto(null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null);
 
     [Fact]
     public async Task CreateEvent_WhenDataIsValid_ShouldReturnSuccess()
@@ -191,7 +191,7 @@ public async Task GetOrganizerEvents_WhenAllOperationsSucceed_ShouldReturnOkWith
 
         // Assert
         var result = Assert.IsType<ActionResult<PaginatedData<GetEventResponseDto>>>(response);
-        var okResult = Assert.IsType<OkObjectResult>(result.Result);
+        var okResult = Assert.IsType<ObjectResult>(result.Result);
         Assert.Equal(StatusCodes.Status200OK, okResult.StatusCode);
 
         var returnedPaginatedData = Assert.IsType<PaginatedData<GetEventResponseDto>>(okResult.Value);
@@ -385,7 +385,7 @@ public async Task GetOrganizerEventsPaginationDetails_WhenAllOperationsSucceed_S
 
         // Assert
         var result = Assert.IsType<ActionResult<PaginationDetails>>(response);
-        var okResult = Assert.IsType<OkObjectResult>(result.Result);
+        var okResult = Assert.IsType<ObjectResult>(result.Result);
         Assert.Equal(StatusCodes.Status200OK, okResult.StatusCode);
 
         var returnedPaginationDetails = Assert.IsType<PaginationDetails>(okResult.Value);
@@ -479,7 +479,7 @@ public async Task GetEvents_WhenAllOperationsSucceed_ShouldReturnOkWithPaginated
 
         // Assert
         var result = Assert.IsType<ActionResult<PaginatedData<GetEventResponseDto>>>(response);
-        var okResult = Assert.IsType<OkObjectResult>(result.Result);
+        var okResult = Assert.IsType<ObjectResult>(result.Result);
         Assert.Equal(StatusCodes.Status200OK, okResult.StatusCode);
 
         var returnedPaginatedData = Assert.IsType<PaginatedData<GetEventResponseDto>>(okResult.Value);
@@ -544,7 +544,7 @@ public async Task GetEventsPaginationDetails_WhenAllOperationsSucceed_ShouldRetu
 
         // Assert
         var result = Assert.IsType<ActionResult<PaginationDetails>>(response);
-        var okResult = Assert.IsType<OkObjectResult>(result.Result);
+        var okResult = Assert.IsType<ObjectResult>(result.Result);
         Assert.Equal(StatusCodes.Status200OK, okResult.StatusCode);
 
         var returnedPaginationDetails = Assert.IsType<PaginationDetails>(okResult.Value);
@@ -602,7 +602,7 @@ public async Task GetEventDetails_WhenAllOperationsSucceed_ShouldReturnOkWithEve
 
         // Assert
         var result = Assert.IsType<ActionResult<GetEventDetailsResponseDto>>(response);
-        var okResult = Assert.IsType<OkObjectResult>(result.Result);
+        var okResult = Assert.IsType<ObjectResult>(result.Result);
         Assert.Equal(StatusCodes.Status200OK, okResult.StatusCode);
 
         var returnedEventDetails = Assert.IsType<GetEventDetailsResponseDto>(okResult.Value);