-
Notifications
You must be signed in to change notification settings - Fork 7
fix: change highlight button text color to black for better contrast #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Light green (#00E6A1) buttons now use black text instead of white for improved readability in dark mode. Fixes #178
WalkthroughOnly one file modified: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a contrast issue with highlight buttons in dark mode by changing the text color from white to black. The mint green background color (#00E6A1 / hsl(171 100% 42%)) remains the same in both light and dark modes, so using consistent black text improves readability.
Key Changes:
- Updated
--highlight-foregroundin dark mode from0 0% 98%(white) to0 0% 3.9%(black) to match light mode
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Greptile OverviewGreptile SummaryChanged the
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant Browser
participant CSS as globals.css
participant Component as Button Component
User->>Browser: Views page in dark mode
Browser->>CSS: Load dark mode styles
CSS->>CSS: Set --highlight-foreground: 0 0% 3.9% (black)
Browser->>Component: Render highlight button
Component->>Component: Apply bg-highlight with text-highlight-foreground
Component->>Browser: Display button with black text on mint background
Browser->>User: Show readable button with improved contrast
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
bassgeta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Summary
Changes the highlight button text color from white to black for improved readability on the mint green background.
Problem
Light green (#00E6A1 / mint) buttons with white text have poor contrast, making button labels difficult to read, especially in dark mode.
Solution
Updated
--highlight-foregroundCSS variable in dark mode from0 0% 98%(white) to0 0% 3.9%(black) insrc/app/globals.css.Testing
Fixes #178
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.