Change usage of DEPENDENTLOADFLAG #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the documentation and build configuration to incorporate the new OIDN_DEPENDENTLOADFLAG option, improving guidance on secure dynamic library loading on Windows. Key changes include:
- Adding a "Security Considerations" section in SECURITY.md with details on dynamic library loading risks and the new CMake option.
- Updating scripts/build.py to automatically set OIDN_DEPENDENTLOADFLAG for Windows packaging.
- Modifying README.md to document the new OIDN_DEPENDENTLOADFLAG parameter.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| SECURITY.md | Adds security documentation for dynamic library loading risks and guidance on the OIDN_DEPENDENTLOADFLAG option. |
| scripts/build.py | Sets a default OIDN_DEPENDENTLOADFLAG value when packaging on Windows. |
| README.md | Updates documentation to include the new OIDN_DEPENDENTLOADFLAG parameter. |
Files not reviewed (1)
- cmake/oidn_platform.cmake: Language not supported
kraszkow
force-pushed
the
kraszkow/dependentloadflag
branch
from
3a65753 to
d9bb7a8
Compare
kraszkow
force-pushed
the
kraszkow/dependentloadflag
branch
2 times, most recently
from
bd84942 to
441d827
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.