Skip to content

Frei/device memory support rebased #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dopitz merged 66 commits into from
Mar 25, 2025
Merged

Frei/device memory support rebased #517

dopitz merged 66 commits into from
Mar 25, 2025

Conversation

@dopitz
Copy link
Collaborator

@dopitz dopitz commented Jan 20, 2025

CI is green, I THINK, the documentation doesn't need additional updates after removing the EMBREE_SYCL_L0_RTAS_BUILDER cmake flag

@dopitz dopitz force-pushed the frei/device_memory_support_rebased branch from 04715ce to 82d5580 Compare January 20, 2025 11:34
@dopitz
Copy link
Collaborator Author

dopitz commented Jan 20, 2025

squashed WIP commits for latest change

@dopitz dopitz force-pushed the frei/device_memory_support_rebased branch from 82d5580 to cee738e Compare January 20, 2025 12:45
@dopitz
Copy link
Collaborator Author

dopitz commented Jan 20, 2025

removed nonessential nightly tests after rthw internal builder removal

@svenwoop
Copy link
Collaborator

svenwoop commented Jan 20, 2025

The kernels/level_zero/ze_rtas.h file is no longer required. The ze_wrapper/zeDeviceGetRTASProperties function can go, and the ZE_RTAS_FORMAT_EXP_VERSION_1/2/MAX are then no longer required. After that removed too it looks fine.

svenwoop
svenwoop requested changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@svenwoop svenwoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The kernels/level_zero/ze_rtas.h file is no longer required. The ze_wrapper/zeDeviceGetRTASProperties function can go, and the ZE_RTAS_FORMAT_EXP_VERSION_1/2/MAX are then no longer required. After that removed too it looks fine.

@dopitz dopitz force-pushed the frei/device_memory_support_rebased branch 2 times, most recently from 8d230cb to 6702c2b Compare January 21, 2025 12:32
@dopitz
Copy link
Collaborator Author

dopitz commented Jan 21, 2025

The kernels/level_zero/ze_rtas.h file is no longer required. The ze_wrapper/zeDeviceGetRTASProperties function can go, and the ZE_RTAS_FORMAT_EXP_VERSION_1/2/MAX are then no longer required. After that removed too it looks fine.

addressed those changes with the latest update

svenwoop
svenwoop previously approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@svenwoop svenwoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@stefanatwork stefanatwork force-pushed the frei/device_memory_support_rebased branch from e7d7945 to 4ccdbd2 Compare February 28, 2025 15:34
@dopitz dopitz force-pushed the frei/device_memory_support_rebased branch 8 times, most recently from e76078a to fffe480 Compare March 7, 2025 14:16
@dopitz dopitz force-pushed the frei/device_memory_support_rebased branch from fc8013b to 20f0ac8 Compare March 12, 2025 08:01
svenwoop
svenwoop reviewed Mar 12, 2025
View reviewed changes
@dopitz dopitz force-pushed the frei/device_memory_support_rebased branch 4 times, most recently from 077457d to 2743687 Compare March 12, 2025 08:54
stefanatwork and others added 13 commits March 12, 2025 11:50
@stefanatwork @dopitz
Fixed uninitialized memory
793418e
@stefanatwork @dopitz
little cleanup
d79bbba
@dopitz
removed EMBREE_SYCL_BVH_DATA_HOST_DEVICE cmake option and made it ena…
5db683c 
…bled by default
@dopitz
skip pvc tests
5625138
@stefanatwork @dopitz
Removed redundant copies in host/device tutorial
dafebdf
@stefanatwork @dopitz
Fixed mistake in async buffer copies
a3afb19 
Fixed forest tutorial
Skip pvc tests in nightly.yml
fixed unititialized empty geometry commit segfault
@dopitz
updated windows public driver, upgraded dg2 tests to ubuntu24.04
5e64422 
fixed coverity issue
update gfx-ubuntu24-internal/public.env for CI
update linux intenal drivers
fix linux release CI
fix integration CI
@dopitz
updated windows internal driver version
ad60c7b
@stefanatwork @dopitz
Version update to 4.4.0
4220be4
@stefanatwork @dopitz
Suppressed warnings with latest clang/sycl compiler
f87d6a1 
warning: first argument in call to 'memset' is a pointer to non-trivially copyable type
@dopitz
removed bvh data host device test, not needed any more
e4ee9f0
@dopitz
disabled internal driver tests for release
4c327f2
@stefanatwork @dopitz
Moved buffer releases in host/device tutorial
23dab66
@dopitz dopitz force-pushed the frei/device_memory_support_rebased branch from 94056a1 to 23dab66 Compare March 12, 2025 10:51
stefanatwork
stefanatwork previously approved these changes Mar 12, 2025
View reviewed changes
@stefanatwork stefanatwork self-requested a review March 17, 2025 10:46
@dopitz dopitz merged commit cba03d6 into devel Mar 25, 2025
4 checks passed
@kraszkow kraszkow mentioned this pull request Mar 26, 2025
Closed
@stefanatwork stefanatwork deleted the frei/device_memory_support_rebased branch October 7, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svenwoop svenwoop svenwoop left review comments

@stefanatwork stefanatwork stefanatwork approved these changes

@kraszkow kraszkow Awaiting requested review from kraszkow

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dopitz @svenwoop @stefanatwork @freibold