Skip to content

Conversation

@ronnyReliefapp
Copy link

Description

This PR fixes the shapefile validation error messages in the backend to match the exact wording required by the ticket. Specifically, it corrects the CRS error mapping and updates the i18n strings for geometry errors.

Useful links

Ticket: https://www.notion.so/cb32a703a24e4e03a3ec47bd6b38c4a4?v=467317821cf24db6b43c59325335e46b&p=24cd463fd8c480218d7bcc037ba055f0&pm=s

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (refactor or addition to existing functionality)

How Has This Been Tested?

  • Verified that the catch block in the projection validation now correctly references the routes.gis.shapefile.errors.format.crs key.
  • Verified that the new keys gaps and overlapping are correctly added to the en.json file and match the ticket's requested wording.

Screenshots

N/A

Checklist:

( * == Mandatory )

  • - I have set myself as assignee of the pull request
  • - My code follows the style guidelines of this project
  • - Linting does not generate new warnings
  • - I have performed a self-review of my own code
  • - I have put the ticket for review, adding the oort-backend team to the list of reviewers
  • - I have commented my code, particularly in hard-to-understand areas
  • - I have put JSDoc comment in all required places
  • - My changes generate no new warnings
  • - I have included screenshots describing my changes if relevant
  • - I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

@ronnyReliefapp ronnyReliefapp changed the title fix: Update i18n messages and fix CRS error message Mab-419 shapefile errors Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants