Skip to content

test(evaluate): dynamically serialize data.pickle #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tristan-f-r merged 12 commits into from
Jul 23, 2025
Merged

test(evaluate): dynamically serialize data.pickle #340

tristan-f-r merged 12 commits into from
Jul 23, 2025

Conversation

@tristan-f-r
Copy link
Collaborator

@tristan-f-r tristan-f-r commented Jul 21, 2025 •
edited
Loading

(apologies for the wait; had to wrangle with my environment to downgrade dependencies)

Blocks #310. This addresses a holdover from #212, and helps with #339.

@tristan-f-r tristan-f-r added the infrastructure misc. changes made to SPRAS itself label Jul 21, 2025
@tristan-f-r tristan-f-r mentioned this pull request Jul 21, 2025
Merged
1 task
@tristan-f-r tristan-f-r requested a review from ntalluri July 21, 2025 21:44
ntalluri
ntalluri requested changes Jul 23, 2025
View reviewed changes
Copy link
Collaborator

@ntalluri ntalluri left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a first pass review

tristan-f-r and others added 7 commits July 23, 2025 08:59
@tristan-f-r @ntalluri
style: use constants and naming convention
7e675d1 
Co-authored-by: Neha Talluri <78840540+ntalluri@users.noreply.github.com>
@tristan-f-r @ntalluri
style: use naming convention
f63b744 
Co-authored-by: Neha Talluri <78840540+ntalluri@users.noreply.github.com>
@tristan-f-r @ntalluri
docs: clarify what pickled file is
23a77be 
Co-authored-by: Neha Talluri <78840540+ntalluri@users.noreply.github.com>
@tristan-f-r @ntalluri
docs: clarify dataset usecase
40614b2 
Co-authored-by: Neha Talluri <78840540+ntalluri@users.noreply.github.com>
@tristan-f-r @ntalluri
style: use constant
397dc00 
(thanks for this!!)

Co-authored-by: Neha Talluri <78840540+ntalluri@users.noreply.github.com>
@tristan-f-r @ntalluri
apply suggestions
f169d55 
Co-Authored-By: Neha Talluri <78840540+ntalluri@users.noreply.github.com>
@tristan-f-r
Merge branch 'umain' into data-pickle-repr
4e1a47e
@tristan-f-r tristan-f-r requested a review from ntalluri July 23, 2025 16:28
ntalluri
ntalluri requested changes Jul 23, 2025
View reviewed changes
@tristan-f-r @ntalluri
re-add file
8bdbe39 
Co-authored-by: Neha Talluri <78840540+ntalluri@users.noreply.github.com>
@tristan-f-r tristan-f-r requested a review from ntalluri July 23, 2025 16:55
@tristan-f-r tristan-f-r merged commit 892b364 into Reed-CompBio:main Jul 23, 2025
15 checks passed
@tristan-f-r tristan-f-r deleted the data-pickle-repr branch July 23, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntalluri ntalluri ntalluri approved these changes

Assignees

No one assigned

Labels

infrastructure misc. changes made to SPRAS itself

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tristan-f-r @ntalluri