style: standardize code to CLAUDE.md standards#1
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Also modernizes typing imports (Dict→dict, List→list, Optional→X|None). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove builtin names (dict, list, tuple, set) from typing imports (artifact of modernize_typing.py script bug) - Auto-fix import sorting and unused imports with ruff - Apply ruff format for consistent style Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add [tool.mypy] with basic settings to Exp_Design/fine_tuning - Root pyproject.toml already had ruff and mypy configuration Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Expand ruff ignore list for structural patterns - Add per-file ignores for F401 false positives (availability checks) - Auto-fix various lint issues in Exp_Design - All ruff format --check and ruff check now pass clean Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dict→dict,Optional[X]→X | None)from __future__ import annotationsto all modulesexcept Exceptionclauses with specific types (requests.RequestException,OSError,ValueError,json.JSONDecodeError, etc.)from typing import dict, listimports caused by modernization script[tool.mypy]config to Exp_Design/fine_tuning/pyproject.toml; expand ruff ignore list in root pyproject.tomlruff format --checkandruff checkcleanTest plan
ruff format --checkpasses on all source dirsruff checkpasses on all source dirs🤖 Generated with Claude Code