-
Notifications
You must be signed in to change notification settings - Fork 67
Add jarrod tracking logic #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jarrod tracking logic #106
Conversation
🔒 Security Scan Results✅ No critical security issues detected. The code has passed all critical security checks. |
8a53a1b to
7d528ad
Compare
🔒 Security Scan Results✅ No critical security issues detected. The code has passed all critical security checks. |
7d528ad to
f34567b
Compare
🔒 Security Scan Results✅ No critical security issues detected. The code has passed all critical security checks. |
🔒 Security Scan Results✅ No critical security issues detected. The code has passed all critical security checks. |
|
Updated gitignore and added README.md |
lperry022
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script runs, but the metric logic needs improvement before approval. Currently only one event_name column is used, so true positives/false positives/false negatives aren’t calculated correctly. fp is hard-coded to 0 and (no_event) always returns perfect scores, which makes the results misleading. Consider updating the script to compare separate ground truth vs predicted columns and compute TP/FP/FN properly.
🔒 Security Scan Results✅ No critical security issues detected. The code has passed all critical security checks. |
|
Thanks for the feedback! I’ve updated prediction_vs_truth.py so it now computes TP/FP/FN properly by comparing truth_event vs pred_event. |
lperry022
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Update to move annotation and analysis scripts into correct folder Player_Tracking/afl_player_tracking_and_crowd_monitoring/player_tracking_logic.
No changes made to code