mac for nether, save on: ticks by default, temp fix for portal bug, /time set 0 first input fix #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not caves b/c hasCeiling does not account for that
/speedrunigt start false does not pause except for the host, and thus only the host can unpause and restart for everyone. there would need to be a packet for pausing to get it to work correctly, idk if you want to add that for this niche use case.
Contributor
Author
|
can't make this a draft on mobile but I want to implement https://discord.com/channels/1033677387143061574/1033763484304941148/1408239505114398771 |
autodetecting was not possible to do completely correctly (ow caves, etc)
this code is supposed to enforce portal animations to contribute exactly 4.0s to igt, as a frame retime would unfortunately, it not only doesn't fulfill its intended purpose (which is sort of a blessing in disguise, because it would remove the additional delay from setting up boat eye, 3 * ticks in boat), but it applies after going through a portal, and now that people do preemptive in the portal (partially due to extra options :/) it causes a lot of verifier time to be spent fixing the timer reversion. the correct way this should be implemented is adjusting the client length of ticks in the portal to be equal to the server length of ticks in the portal, and that will be done at some point during the tick timing reform.
tildejustin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plus a little bit more of a thought to performance
I have tested this pretty thoroughly
Merge base version