Changes made Jun 6, 2021 onwards #69
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even build numbering on master
Displays adjusted Cost but also uses Count=Cost to get around card image caching
Including spectating
To match 'Race' for minions
- Replaces Individual view isValid functions - Moves view enabled setting checks to use ViewConfig - Adds view to panel
LastPlayedView definitely not working Title is a bit messy?
Add SinglesPanel for single entry views
- main.yml - Rename to `Build+Release` from `Build+Release on PR` - Switch trigger from `pull_request` to `push` - build+upload.yml - Copy main.yml content minus "create_release" step (retaining separate build versioning) - Upload zip instead of just dll
- v2.2.3 to v4.6.2
And remove unused 7z generated zip
And remove double zip extension
Reference AnimatedCards collection instead of Items collection from removed ItemsControl base
Graveyard UI not showing: MissingMethodException AnimatedCardList.Update Just to note that ChatGPT *did not* help, at all
Contributor
Author
|
I hadn't meant to leave this pull request open quite this long, so apologies for the 250+ commits. Change log highlights
Understand entirely if no-one wants to deal with this lot. |
- Soft removed with QuestlineVisibility setting - FriendlyQuestlineEnabled value and default set to False - EnemyQuestlineEnabled value and default set to False - Closes #17 Can be re-enabled by adding ``` <Setting> <Name>QuestlineVisibility</Name> <Value>Visible</Value> </Setting> ``` to `%appdata%\HearthstoneDeckTracker\Plugin.Graveyard\Settings.xml`
Supports multiple card versions, where a card name has more than one id associated with it e.g. `Tess Greymane` in **The Witchwood** and **Core**
- Enable/Disable all card-based view triggers - Resurrection/Deathrattle views shown based only on player 'Resurrect' and 'Deathrattle' settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #68
Resolves #64
Closes #63
Resolves #62
Resolves #53