Merged
Conversation
mshriver
force-pushed
the
add-radio
branch
2 times, most recently
from
f5b856f to
9dd0b86
Compare
mshriver
requested review from
LightOfHeaven1994,
RonnyPfannschmidt,
Victoremepunto and
digitronik
Contributor
Author
|
Would love to hear early thoughts on the Radio design and behavior, planning on including an OUIA class along with it, but that will require a non-trivial class because of the DOM attribute locations. |
mshriver
force-pushed
the
add-radio
branch
2 times, most recently
from
3a480f9 to
2987648
Compare
PF4 has no radio group, just radio provide unit tests as well Radio has description/label/checkbox widgets that should be consistent in practice body will have to be replaced within a Radio subclass when used in practice on radios that have additional widgets in their body Filling a radio just clicks the checkbox, Radio.body will have to be filled separately from the selection itself. child_widget_accessed could be used in the body definition, maybe there's a better strategy to define the body widgets?
LightOfHeaven1994
approved these changes
Oct 26, 2022
Collaborator
LightOfHeaven1994
left a comment
LightOfHeaven1994
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the effort!
Member
|
ahhhh I'm late. |
Member
|
Updating for both thanks Mike! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PF4 has no radio group, just radio
Radio has description/label/checkbox widgets that should be consistent
in practice
body will have to be replaced within a Radio subclass when used in
practice on radios that have additional widgets in their body
Filling a radio just clicks the checkbox, Radio.body will have to be
filled separately from the selection itself.
child_widget_accessed could be used in the body definition, maybe
there's a better strategy to define the body widgets?
OUIA integration will be interesting, as the component type and ID are set on the
<input>element, not on the root DIV. Will likely have to play with locator construction.