Prepare Jira escalation for Cloud migration #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch from username-based to accountId-based user identification to support Jira Cloud migration: - Use accountId for @mention syntax ([~accountId:...] format) - Compare comment authors by accountId instead of email - Add _get_user_account_id helper for safe accountId extraction - Add _get_user_email helper with None handling for Cloud privacy - Handle optional assignee_email (may be None in Cloud) Includes 7 unit tests for the new helper methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Switch from username-based to accountId-based user identification to support Jira Cloud migration:
[~accountId:...]format)_get_user_account_idhelper for safe accountId extraction_get_user_emailhelper with None handling for Cloud privacyIncludes 7 unit tests for the new helper methods.
Context
This PR is part of the Red Hat Jira Cloud migration effort tracked in INTEROP-8496.
Why these changes are needed
Jira Cloud uses
accountIdinstead ofusernamefor user identification:[~username]mention syntax will silently fail in Cloud (no notification sent)None)Changes made
src/escalation/jira_escalation.pytests/.../test_jira_escalation.pyUAT Follow-up
The following should be verified during UAT against Jira Cloud:
assign_issueemail lookup works in Cloud (src/objects/jira_base.py)get_field("assignee")string output displays correctly in issue tables