✨ Provide KPI metrics view #700
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superbuggy
force-pushed
the
AEGIS-196-KPI-ui
branch
2 times, most recently
from
e631cba to
7bff0c8
Compare
superbuggy
force-pushed
the
AEGIS-196-KPI-ui
branch
2 times, most recently
from
5ba78b7 to
eb635f3
Compare
superbuggy
force-pushed
the
AEGIS-196-KPI-ui
branch
from
2ae407c to
66fe1bb
Compare
Fix type error ✅ Fix tests Update CHANGELOG.md ✅ Fix tests 🔧 Try different syntactic expression to avoid CI error Bump vitest version 🔧 Try yet another syntactic expression to avoid CI error 🔧 Try yet another syntactic expression to avoid CI error 🔧 Try node upgrade in test CI ✨ Preserve date range selection 🔧 Refactor test to not use hoisted Fix formatting 🔥 Remove test CI debugging script
Add ean values ✨ Provide filtering by build ✅ Fix test
superbuggy
force-pushed
the
AEGIS-196-KPI-ui
branch
from
66fe1bb to
832d2b5
Compare
C-Valen
reviewed
Dec 17, 2025
Member
C-Valen
left a comment
C-Valen
left a comment
There was a problem hiding this comment.
Generally looking good, just some small considerations/questions.
Also as discussed internally in meeting would be convenient to show the total KPI across all features.
Comment on lines
+106
to
+113
| { | ||
| path: '/kpi', | ||
| name: 'kpi-metrics', | ||
| component: KpiMetricsView, | ||
| meta: { | ||
| title: 'KPI Metrics', | ||
| }, | ||
| }, |
Member
There was a problem hiding this comment.
Will we make the data publicly available?
| }); | ||
| }); | ||
|
|
||
| describe('getKpiMetrics', () => { |
Member
There was a problem hiding this comment.
Even being the function part of the service, I think it could be better organized in a individual test suite, wdyt?
Comment on lines
+12
to
+15
| 'suggest-cwe': 'Suggest CWE', | ||
| 'suggest-description': 'Suggest Description', | ||
| 'suggest-impact': 'Suggest Impact', | ||
| 'suggest-statement': 'Suggest Statement Mitigation', |
| type FeatureLabelsWithAllType = keyof typeof FeatureLabelsWithAll; | ||
| const kpiMetrics = ref<AegisKpiMetrics | null>(null); | ||
| // const chosenFeature = ref<keyof typeof FeatureLabels>('all'); |
Member
There was a problem hiding this comment.
Is this still needed for some indication?
| </button> | ||
| </section> | ||
| <h3 v-if="!isFilteredDateRange">Average (All Time)</h3> | ||
| <h3 v-if="isFilteredDateRange">Average (AcrossDate Range)</h3> |
Member
There was a problem hiding this comment.
Suggested change
| <h3 v-if="isFilteredDateRange">Average (AcrossDate Range)</h3> | |
| <h3 v-if="isFilteredDateRange">Average (Across Date Range)</h3> |
Comment on lines
+17
to
+18
| ### Added | ||
| * Add KPI metrics data visualization (`AEGIS-196`) |
Member
There was a problem hiding this comment.
We can use the existing Added block at the top
| }); | ||
| } catch (error) { | ||
| console.error('AegisAIService::sendFeedback() Error:', error); | ||
| throw error; |
| const chosenFeature = ref<FeatureLabelsWithAllType>('all'); | ||
| async function fetchKpiMetrics(feature: FeatureLabelsWithAllType = 'all') { | ||
| const featureKey = feature === 'all' ? 'all' : (feature as any); |
Member
There was a problem hiding this comment.
Cant we avoid any typing
const featureKey: 'all' | FeatureLabel = feature;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AEGIS-196 KPI Metrics View
Checklist:
Summary:
Changes:
Adds KPI metrics view
Adds UI library for data visualization
Considerations: