Add auto-merge for my commits (just testing)#28
Merged
joselsegura merged 1 commit intoRedHatInsights:masterfrom Mar 24, 2026
Merged
Add auto-merge for my commits (just testing)#28joselsegura merged 1 commit intoRedHatInsights:masterfrom
joselsegura merged 1 commit intoRedHatInsights:masterfrom
Conversation
joselsegura
requested review from
Bee-lee,
Jakub007d,
JiriPapousek,
ikerreyes,
juandspy,
lenasolarova and
matysek
as code owners
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Summary by CodeRabbit
WalkthroughAdds a GitHub Actions workflow that triggers on pull_request events and, when the PR author is Changes
Sequence Diagram(s)sequenceDiagram
participant Workflow as "GitHub Actions\nWorkflow"
participant Runner as "Actions\nRunner\n(ubuntu-latest)"
participant GH as "GitHub\n(Events / PR API)"
Workflow->>GH: Receive pull_request event
Workflow->>Runner: Start job (if author == joselsegura)
Runner->>GH: Read PR metadata (author, html_url)
alt author == joselsegura
Runner->>GH: gh pr review --approve (using GITHUB_TOKEN)
Runner->>GH: gh pr review --approve (using INSIGHTSDROID_TOKEN)
Runner->>GH: gh pr merge --auto --merge (enable auto-merge)
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/bots-automerge.yaml (1)
3-3: Specify event types to avoid redundant workflow runs.Without specifying event types, this workflow triggers on
opened,synchronize, andreopened. This means every push to the PR branch re-runs the approval and merge steps. Consider restricting toopenedonly.Suggested fix
-on: pull_request +on: + pull_request: + types: [opened]🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/bots-automerge.yaml at line 3, The workflow currently triggers on all pull_request activity via the "on: pull_request" declaration which causes redundant runs; update the workflow trigger to restrict event types by replacing the generic "on: pull_request" with a typed trigger (e.g., "on: pull_request: types: [opened]") so the jobs only run when a PR is opened; ensure the "on" block in the workflow file is updated accordingly and validate the YAML indentation/format to keep the rest of the workflow (approval/merge jobs) intact.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/bots-automerge.yaml:
- Around line 25-29: The "InsightsDroid approves the PR" step currently attempts
to have InsightsDroid approve its own PR which GitHub forbids; update that job
step (named "InsightsDroid approves the PR") to either add continue-on-error:
true so the workflow proceeds if the approval fails, or guard the step with a
conditional that skips it when the PR author/actor equals "InsightsDroid" (use
the github.actor or github.event.pull_request.user.login context) while still
keeping the existing run and env entries (PR_URL and GH_TOKEN) intact.
---
Nitpick comments:
In @.github/workflows/bots-automerge.yaml:
- Line 3: The workflow currently triggers on all pull_request activity via the
"on: pull_request" declaration which causes redundant runs; update the workflow
trigger to restrict event types by replacing the generic "on: pull_request" with
a typed trigger (e.g., "on: pull_request: types: [opened]") so the jobs only run
when a PR is opened; ensure the "on" block in the workflow file is updated
accordingly and validate the YAML indentation/format to keep the rest of the
workflow (approval/merge jobs) intact.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e89d91bc-722b-474f-bf55-d9617295707d
📒 Files selected for processing (1)
.github/workflows/bots-automerge.yaml
juandspy
reviewed
Mar 24, 2026
JiriPapousek
previously approved these changes
Mar 24, 2026
joselsegura
force-pushed
the
add_autoupdate_reviews
branch
from
42a29db to
d94ac11
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/bots-automerge.yaml:
- Around line 14-18: The GitHub Actions expression under the if: block in
bots-automerge.yaml is invalid because the block scalar (|) treats lines with #
as literal text and the expression parser rejects # characters; fix by replacing
the multi-line literal with a single valid expression (e.g.,
github.event.pull_request.user.login == 'joselsegura') or by removing the
commented lines inside the block and, if you need notes, move them to proper
YAML comments above the if: key (so edit the if: expression content to contain
only a valid GitHub Actions boolean expression and remove or relocate the lines
starting with #).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3574a770-4599-4ac0-b79a-9902fbd5bc2c
📒 Files selected for processing (1)
.github/workflows/bots-automerge.yaml
joselsegura
force-pushed
the
add_autoupdate_reviews
branch
from
d94ac11 to
ea17a08
Compare
JiriPapousek
approved these changes
Mar 24, 2026
juandspy
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In order to test the posibilities we have using
CODEOWNERSfile, I need an auto approve/auto merge CI to be run.I modified the one for bots in order to auto-approve a PR made by me
Type of change
Testing steps