Refactor typecard. #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variable printing was put into a function for better readability. CHAR_BIT is used instead of a literal 8 for better portability. The system bit-width is now detected by checking the size of a pointer. The proper preprocesor macro is now used for testing for __int128_t. Endian testing macros were moved out of main, support for PDP endianness has been added, and the proper GCC endian preprocessor macros are used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a general PR to fix a couple bugs and improve the portability of
typecard.Here is a list of the changes:
intptr_tto the list of types printed.CHAR_BITfor bits-per-byte instead of the literal8.sizeof(void*)instead of__LP64__toallow for non-32/64-bit values.
presence of
__int128_t.