Use tool for loot to enable silk touch / fortune#725
Open
jshipley wants to merge 3 commits intoRearth:1.21from
Open
Use tool for loot to enable silk touch / fortune#725jshipley wants to merge 3 commits intoRearth:1.21from
jshipley wants to merge 3 commits intoRearth:1.21from
Conversation
Owner
|
Hi, thanks for the PR. I'm currently in the process of cleaning up some other stuff but will take a look at this real soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using a chainsaw or prometheum axe to chop down an entire tree, the enchantments on the tool will now be respected when it comes to calculating loot drops.
How Has This Been Tested?
I have tested chopping down trees with enchanted and unenchanted chainsaws and prometheum axes on Fabric and NeoForge. I get leaves when the axe has Silk Touch as expected.
Checklist:
There wasn't really any new code, I just replaced the <Level, BlockPos> Tuple with a record that also contains the axe ItemStack, and changed which version of Block.getDrops() gets called.