fix: example error with empty config key#27
Open
bazuka5801 wants to merge 1 commit intoReallySmallSoftware:masterfrom
Open
fix: example error with empty config key#27bazuka5801 wants to merge 1 commit intoReallySmallSoftware:masterfrom
bazuka5801 wants to merge 1 commit intoReallySmallSoftware:masterfrom
Conversation
remove config key from initialization, because if we use this key with empty, calling firestore throwing errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #28
I spent few hours to understand where my bug, and I think many people who want use this plugin intersects with this problem.
remove config key from initialization, because if we use this key with empty, calling firestore throwing errors.
Fixes #
Android
IOS
What I think?
I think may be add same additional checking appid in config object for android as in IOS code.=
Proposed Changes