e2e test for withdrawals L2-initiate -> forking -> L1-finalize#143
Merged
e2e test for withdrawals L2-initiate -> forking -> L1-finalize#143
Conversation
josojo
commented
Jan 3, 2024
| bool useFirstChild, | ||
| bool useChildTokenAllowance | ||
| ) public onlyForkManger onlyAfterForking { | ||
| ) public onlyAfterForking { |
Collaborator
Author
There was a problem hiding this comment.
Since all tokens are no longer accessible in the old bridge contract and they need to be withdrawn in the new contract, I think its fine if everyone can push them to the new chain. But I will rework this in one of my next PRs anyway
edmundedgar
approved these changes
Jan 3, 2024
Contributor
edmundedgar
left a comment
edmundedgar
left a comment
There was a problem hiding this comment.
Approved apart from my minor quibble with the wording of that comment
contracts/ForkableBridge.sol
Outdated
|
|
||
| /** | ||
| * @dev Allows the forkmanager to take out the forkonomic tokens | ||
| * @dev Allows to take out the forkonomic tokens |
Contributor
There was a problem hiding this comment.
Comment: Allows -> Allows anyone
Contributor
There was a problem hiding this comment.
Come to think of it I would write this as
Allows anyone to take out their forkonomic tokens
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/**
*/