Open
Conversation
…jwt validation with Okta's golang lib. Made a few hacks to get it working.
… only work with `Authorization: token`, not `access_token` (would it broke gitlab, bitbucket?).
thomasyip
changed the title
thomasyip
commented
Nov 26, 2018
| @@ -1,8 +1,14 @@ | |||
| FROM netlify/go-glide:v0.12.3 | |||
Author
There was a problem hiding this comment.
The original docker has golang 1.8. Some dep fails to build with it.
thomasyip
commented
Nov 26, 2018
| help: ## Show this help. | ||
| @awk 'BEGIN {FS = ":.*?## "} /^[a-zA-Z_-]+:.*?## / {sub("\\\\n",sprintf("\n%22c"," "), $$2);printf "\033[36m%-20s\033[0m %s\n", $$1, $$2}' $(MAKEFILE_LIST) | ||
|
|
||
| all: lint vet test build ## Run the tests and build the binary. |
Author
There was a problem hiding this comment.
lint fails with original master.
Author
There was a problem hiding this comment.
It works with newer golang version. It is reenabled.
thomasyip
force-pushed
the
ORGANIC-389-Temp-Get-Git-Gateway-To-Work
branch
from
405e7f9 to
8b2c74f
Compare
…nto auth.go. Got it compiled.
thomasyip
force-pushed
the
ORGANIC-389-Temp-Get-Git-Gateway-To-Work
branch
from
8b2c74f to
e70ec30
Compare
thomasyip
changed the title
thomasyip
force-pushed
the
ORGANIC-389-Temp-Get-Git-Gateway-To-Work
branch
from
46e6467 to
57c0690
Compare
thomasyip
force-pushed
the
ORGANIC-389-Temp-Get-Git-Gateway-To-Work
branch
from
57c0690 to
163a708
Compare
thomasyip
force-pushed
the
ORGANIC-389-Temp-Get-Git-Gateway-To-Work
branch
from
760c722 to
76f77fe
Compare
csdurfee
approved these changes
Nov 28, 2018
csdurfee
left a comment
csdurfee
left a comment
There was a problem hiding this comment.
Thomas and I discussed these changes and I am good with them.
Author
|
Created PR onto Netlify's original repo: netlify#24 If they take the patch, we can close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RP prepare for review. Will generalize a bit more before sending PR to
netlify, for examplesAdd some kind of build/run test with circle-ci?(skipped, no admin access to circle-ci)- Summary
- Test plan
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)