Skip to content

Add support for mount options#3

Open
pagdot wants to merge 3 commits intoRealOrangeOne:masterfrom
pagdot:addMountOptions
Open

Add support for mount options#3
pagdot wants to merge 3 commits intoRealOrangeOne:masterfrom
pagdot:addMountOptions

Conversation

@pagdot
Copy link
Contributor

@pagdot pagdot commented Feb 27, 2021

In the config.txt all additional columns get treated forwarded as parameters

Copy link
Owner

@RealOrangeOne RealOrangeOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks great, although you'll need to make shellcheck happy with the lack of quotes.

@pagdot
Copy link
Contributor Author

pagdot commented Feb 27, 2021

Hmm.... The issue is that the missing quotes are intentional because I want it to split to multiple arguments. I'll take a look though into using a bash array instead which could be better altogether because at the moment I can't use quotes in the config.txt to escape whitespaces

@pagdot
Copy link
Contributor Author

pagdot commented Feb 27, 2021

Hmm.... I don't know right now an alternative way to implement proper parsing without relying on eval. Would it be okay for you to trick shellcheck by assigning an empty array to arr? Like with arr=()?

@pagdot pagdot force-pushed the addMountOptions branch 5 times, most recently from f573f60 to 2a1ccdc Compare August 24, 2021 23:20
pagdot added 3 commits August 25, 2021 01:21
In the config.txt all additional columns get treated forwarded as parameters
Changed the line parsing to parse the line as array with `eval` to keep the parameter expansion
@pagdot
Copy link
Contributor Author

pagdot commented Aug 24, 2021

Hi, fixed it finally after ignoring it for.... half a year.....

I've setup the build system in my own fork to auto build for new rclone version which I'll use moving forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants