Skip to content

Conversation

@JC-Coder
Copy link

@JC-Coder JC-Coder commented Nov 21, 2025

Date: 21/11/2025

Developer Name: JC CODER


Issue Ticket Number

Closes #1377
Closes #1380

Description

This PR fixes the issue with the Event page route when opened from the status site. Removed the trailing .html extension which caused the issue.
This also fixes failing tests due to some tag and date mismatch

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1
Screen.Recording.2025-11-21.at.10.05.10.AM.mov

Test Coverage

Screenshot 1 image

Additional Notes

@vercel
Copy link

vercel bot commented Nov 21, 2025

@JC-Coder is attempting to deploy a commit to the anujchhikara's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link

coderabbitai bot commented Nov 21, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Summary by CodeRabbit

  • Bug Fixes

    • Updated Events link to reflect URL changes.
  • Tests

    • Updated test expectations for Events link.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

Fixed a 404 error on the Events page by removing the .html extension from the EVENTS_URL constant and updating the corresponding test expectation to match the corrected URL.

Changes

Cohort / File(s) Summary
Events URL correction
src/constants/url.ts, __tests__/Unit/Components/Navbar/Navbar.test.tsx
Updated EVENTS_URL constant from https://www.realdevsquad.com/events.html to https://www.realdevsquad.com/events and synchronized test expectation to reflect the corrected URL

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Straightforward constant value change applied consistently across two related files
  • No logic modifications or control flow changes
  • Simple string replacement pattern repeated uniformly

Poem

🐰 A hop and a skip, the .html did slip,
From links that were broken, a new path was spoken,
Now /events rings clear, no 404 fear—
The page loads with cheer, the fix is sincere! ✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The PR successfully addresses issue #1377 by removing the .html extension from EVENTS_URL, which fixes the 404 error when navigating to the Events page.
Out of Scope Changes check ✅ Passed All changes are directly related to fixing the Events URL issue. The modifications to url.ts constant and corresponding test update are scoped to the linked issue #1377.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately describes the main change: removing .html extension from EVENTS_URL and updating the corresponding test expectations to fix the failing test.
Description check ✅ Passed The PR description clearly relates to the changeset, explaining the removal of the .html extension from the EVENTS_URL to fix the event page routing issue.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

…ttribute for accessibility

- Modified  to use regex for matching dynamic year values in the  function test.
- Updated  to use regex for matching dynamic year values in the task started date test.
- Added  to the list items in  for improved accessibility.
@JC-Coder JC-Coder changed the title fix: update EVENTS_URL to remove .html extension fix: update event page routing and failing tests Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests failing Bug : Events Page Not Found

2 participants