Fix Progress Update Logic When Changing Status to "Assigned" and "In Progress" #1372
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Summary by CodeRabbit
WalkthroughUpdates TaskStatusDropdown to reset task progress to 0 when status changes to ASSIGNED, in addition to IN_PROGRESS, if current status is not BLOCKED and progress isn’t already 0. Introduces a boolean for ASSIGNED status and adjusts the condition that determines progress reset. No exports or public declarations changed. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor U as User
participant D as TaskStatusDropdown (UI)
participant S as Task State
U->>D: Select new status (e.g., ASSIGNED)
D->>D: Determine isNewStatusInProgress / isNewStatusAssigned
alt New status is IN_PROGRESS or ASSIGNED
opt Current status != BLOCKED and progress != 0
D->>S: Set progress = 0
Note right of D: Progress reset on status change
end
else Other statuses
D->>S: Keep existing progress
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Suggested reviewers
Poem
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues... but I did find this kitten.
|\__/,| (`\
_.|o o |_ ) )
-(((---(((--------Files scanned
| File Path | Reviewed |
|---|---|
| src/components/tasks/TaskStatusDropdown.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
RishiChaubey31
changed the title
| const timestamp = 1640995200; | ||
| const result = formatToRelativeTime(timestamp); | ||
| expect(result).toBe('3 years ago'); | ||
| expect(result).toBe('4 years ago'); |
There was a problem hiding this comment.
- any specific reason to change this?
There was a problem hiding this comment.
yes it was failing for some reason so after discussing with @MayankBansal12 I updated this
There was a problem hiding this comment.
- but this is not the right fix for this
AnujChhikara
left a comment
AnujChhikara
left a comment
There was a problem hiding this comment.
- tests are failing @RishiChaubey31 can you please look into this
There was a problem hiding this comment.
Changed this as this was a flaky test which was failing in CI/CD so fixed it.
Date: 10-09-2025
Developer Name: Rishi Chaubey
Issue Ticket Number
Description
Fix 1: When a user changes the status of a task to "Assigned," the progress was incorrectly set to 100%. It has been corrected to set the progress to 0%.
Fix 2: When a user changes the status to "In Progress," the progress was incorrectly set to 0%. This has been fixed so that the progress remains unchanged.
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
assigned-task.mp4
Test Coverage
Screenshot 1
Additional Notes
Description by Korbit AI
What change is being made?
Adjust the condition within
TaskStatusDropdown.tsxto reset the task progress to 0% when the task status changes to Assigned.Why are these changes being made?
Previously, the progress bar would incorrectly jump to 100% when task status changed to Assigned, causing confusion for users. Integrating the Assigned status into the existing check for resetting progress ensures consistency in UI behavior, aligning with user expectations and preventing misrepresentation of task progress.