bug-fix: #225 re-design task card #1134
Conversation
|
@palakgupta2712 is attempting to deploy a commit to the RDS-Team Team on Vercel. A member of the Team first needs to authorize it. |
| $orange: #ffa500; | ||
| $light-red-1: #ffb0b0; | ||
| $light-red-2: #ffdddd; | ||
| $light-red-2: #fef2f2; |
There was a problem hiding this comment.
what is same as above? have deleted the hex and added a new.
There was a problem hiding this comment.
Might affect other than task card items?
If not we can ignore it
There was a problem hiding this comment.
Please try not adding comments like Same as above, it confuses the Author. If you want to reference add comments beforehand then copy the link of that comments which are repeated and add comment links in the next ones
There was a problem hiding this comment.
Also be specific to what changes are you referring to also helps
src/components/tasks/card/index.tsx
Outdated
| isDevMode={isDevMode} | ||
| /> | ||
| ) : ( | ||
| <div className={styles.statusContainer} style={{}}> |
| <p | ||
| data-testid="task-status" | ||
| className={`${styles.statusText} ${ | ||
| styles[ |
There was a problem hiding this comment.
Should be moved out for better readability
There was a problem hiding this comment.
NIT: we can keep it in a variable outside jsx for some readability
| data-testid="task-status" | ||
| className={`${styles.statusText} ${ | ||
| styles[ | ||
| `statusText${handleStatusTextColor( |
There was a problem hiding this comment.
handleStatusTextColor is returning the color name, that is the diff.
There was a problem hiding this comment.
NIT: we can keep it in a variable outside jsx for better readability
Tasks
|
| <p | ||
| className={`${styles.statusTextIndicator} ${ | ||
| styles[ | ||
| `statusTextIndicator${handleStatusTextColor( |
There was a problem hiding this comment.
handleStatusTextColor is returning the name, that is the diff.
There was a problem hiding this comment.
NIT: we can keep it in a variable outside jsx for better readability
| <span className={styles.cardStrongFont} role="button" tabIndex={0}> | ||
| {!cardDetails.endsOn ? 'TBD' : fromNowEndsOn} | ||
| </span> | ||
| <> |
There was a problem hiding this comment.
div was creating an issue here, in styling.
There was a problem hiding this comment.
I meant to say fragment is also not needed here as we have single single span element
4 participants
Date: 18/02/2024
Developer Name: Palak Gupta
Issue Ticket Number
Description
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Test Coverage
Screenshot 1
Additional Notes