fix: shimmer is applied to only those data that are loaded later #916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add test coverage and screen shot for test cases passing! |
Achintya-Chatterjee
approved these changes
Nov 18, 2024
joyguptaa
approved these changes
Nov 18, 2024
Merged
sunilk429
pushed a commit
to sunilk429/website-dashboard
that referenced
this pull request
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 18/11/2024
Developer Name: Kavya Rishi
Issue Ticket Number
RealDevSquad/website-status#1282
Description
The shimmer effect is applied to that data that is not loaded yet.
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Screencast.from.18-11-24.11.47.17.PM.IST.webm
Test Coverage
Additional Notes