Dev to Main Sync #200

MayankBansal12 · 2025-05-12T20:38:15Z

Date: 13-03-2025

Developer Name: @Shyam-Vishwakarma @mbramani

Issue Ticket Number

PR's Going in these Sync:-

Description

Adds integrations tests and a couple of bug fixes related to skill endorsements.

Documentation Updated?

Yes
No

Under Feature Flag

Yes
No

Database Changes

Yes
No

Breaking Changes

Yes
No

Development Tested?

Yes
No

Screenshots

Staging Proofs

Proof for #195
https://github.com/user-attachments/assets/3baa8f66-4fc5-4e68-9424-6204a3e62723

Proof for #198

Tests

CreateEndorsementIntegrationTest -

GetAllSkillIntegrationTest -

CreateSkillIntegrationTest -

GetEndorsementBySkillIdIntegrationTest -

Additional Notes

* add integration tests for GET v1/skills, add test DB configuration * fix format violation

* add integration tests for GET v1/skills, add test DB configuration * fix format violation * Update test configuration to create schema using Flyway * Add integration test for v1/skills/requests route * Add custom result matcher for mockMvc responses * Add security config for test environment to mock logged in users * Add Use of CustomMockUser instead of AuthCookie * Add spring-security test dependency

)

* change status code from 200 to 201 * add integration tests for POST v1/skills

…sts/{skillId}/action (#188) * fix:update formatting of request-body * replace hardcoded JSON strings by serializing object of SkillRequestActionRequestDto

* fix: update failsafe config, add dotenv dependency * fix: replace hardcoded test-db-name with env variable * fix: move integration test classes to integration package * add test container manager * fix: remove test-db config as it is not required * fix: remove print statements * fix: remove disabled from unit tests, update config of surefire to locate unite tests correctly * fix: upgrade github actions runner version to v4 * fix: make version of mysql db to a more specific version tag * fix: update config to include multilevel folder * fix: update expected status to status code * fix: remove unnecessary config and functions * fix: fix typos in commands --------- Co-authored-by: yash raj <yashraj0207@outlook.com>

* fix: remove harcoded value from test container * fix: add integration tests for GET /v1/skills/{id}/endorsements * fix: refactor the code, remove unused dependence, redundant comments

…196) * fix: restrict endorsement requests to only those user has endorsed * test: verify endorsement request privacy controls * chore: add dev feature flag * fix: simplify skill request retrieval logic for superusers and non dev feature flag * fix: optimize user view model retrieval * test: enhance integration tests * fix: optimize endorsement retrieval by reducing redundant user detail fetches * fix: update skill request retrieval logic * refactor: rename devMode parameter to isDev for clarity in SkillService and SkillsApi * refactor: remove unused findByEndorseIdAndSkillIdAndEndorserId method from EndorsementRepository * test: add integration negative tests for skill requests with dev flag scenarios --------- Co-authored-by: Mayank Bansal <mayankbansal125@gmail.com>

coderabbitai · 2025-05-12T20:38:21Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

… endorsement creation (#198) * fix: avoid creating duplicate endorsements, add integration tests * fix: update name of the test * fix: update formatting * test: add test to validate skill creation on a diff skill than those that have endorsements * fix: update query formatting * fix: update query to scan only endorsement table, as joining user-skills is redundant * test: add test-case to test flow when user is unauthorized * fix: update test name, createUrl(), log * add class to contain constant messages across app * fix: use constants defined in Constants.java * fix: use constants defined in Constants.java * fix: make constructor of Constants private to prevent instantiation * fix: import ExceptionMessages from Constants * fix: update status from 409 to 405 * fix: update query, subquery is redundant * fix: add logging level for each envioronment * fix: avoid appending timestamps, message etc, update error message * fix: add constructor for GenericResponse to create obj with message only

Shyam-Vishwakarma · 2025-05-15T19:28:13Z

Staging proof for my changes:
Before, duplicate endorsement was being created but now it is not allowed.

Screenshot

Shyam-Vishwakarma and others added 8 commits October 23, 2024 18:15

Add integration tests for GET v1/skills route (#161)

36f6a57

* add integration tests for GET v1/skills, add test DB configuration * fix format violation

add integration test for POST /v1/skills/requests/{skillId}/action (#177

52cb8d9

)

Test: Integration Test for POST /v1/skills (#182)

907bf83

* change status code from 200 to 201 * add integration tests for POST v1/skills

fix: update formatting of integration tests for POST /v1/skills/reque…

c71d767

…sts/{skillId}/action (#188) * fix:update formatting of request-body * replace hardcoded JSON strings by serializing object of SkillRequestActionRequestDto

test: integration test for GET /v1/skills/{skillId}/endorsements (#194)

fab2c17

* fix: remove harcoded value from test container * fix: add integration tests for GET /v1/skills/{id}/endorsements * fix: refactor the code, remove unused dependence, redundant comments

iamitprakash had a problem deploying to staging May 15, 2025 17:30 — with GitHub Actions Error

iamitprakash had a problem deploying to staging May 15, 2025 18:40 — with GitHub Actions Error

fix: update formatting of queries (#204)

785af90

iamitprakash temporarily deployed to staging May 15, 2025 19:15 — with GitHub Actions Inactive

Shyam-Vishwakarma mentioned this pull request May 15, 2025

fix: update formatting of queries #204

Merged

10 tasks

Merge branch 'main' into develop

29a45b5

iamitprakash temporarily deployed to staging May 16, 2025 17:26 — with GitHub Actions Inactive

iamitprakash approved these changes May 16, 2025

View reviewed changes

iamitprakash merged commit cc99b21 into main May 16, 2025
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Dev to Main Sync #200

Dev to Main Sync #200

Uh oh!

MayankBansal12 commented May 12, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented May 12, 2025 •

edited

Loading

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Shyam-Vishwakarma commented May 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Dev to Main Sync #200

Dev to Main Sync #200

Uh oh!

Conversation

MayankBansal12 commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Ticket Number

PR's Going in these Sync:-

Description

Documentation Updated?

Under Feature Flag

Database Changes

Breaking Changes

Development Tested?

Screenshots

Additional Notes

Uh oh!

coderabbitai bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Shyam-Vishwakarma commented May 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MayankBansal12 commented May 12, 2025 •

edited

Loading

coderabbitai bot commented May 12, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)