Metrics 3.1.0 update and suffixing possibility for metrics name#24
Open
htimur wants to merge 2 commits intoReadyTalk:masterfrom
Open
Metrics 3.1.0 update and suffixing possibility for metrics name#24htimur wants to merge 2 commits intoReadyTalk:masterfrom
htimur wants to merge 2 commits intoReadyTalk:masterfrom
Conversation
htimur
changed the title
|
This looks pretty reasonable - I'm sorry I haven't had time to look at this previously, and I'm not sure if folks at ReadyTalk are going to have time to look at this in the future. Sorry about that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our architecture, we run statsd on each server, and they all send to a central graphite server and it's pretty useful to have the possibility to suffix the metric name with current host name.
This pull request allows you to send metrics like "some.metric.name.with.suffix.%s" if you configure the suffix as "host1" it'll be replaced as "some.metric.name.with.suffix.host1".