Skip to content

Conversation

@sergeleger
Copy link
Collaborator

PR Goal?

Fixes the low contrast of black text on a dark-blue background. Uses the predefined Sass themes for implementation.

Fixes?

Closes #498

Feedback sought?

Confirmation of approach.

Priority?

low

Tests added?

no

How to test?

  • create a new read along
  • in step 2, change to the dark theme (click on settings icon)
  • instructions "Upload an image for this page" should now be displayed in white text.

Confidence?

High.

Version change?

No.

@semanticdiff-com
Copy link

semanticdiff-com bot commented Dec 22, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  packages/studio-web/src/assets/bundle.js  97% smaller
  packages/web-component/src/scss/modules/_pages.scss Unsupported file format

@sergeleger sergeleger requested a review from deltork December 22, 2025 16:00
@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2025

PR Preview Action v1.6.3
Preview removed because the pull request was closed.
2025-12-23 11:20 UTC

Copy link
Collaborator

@deltork deltork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks Serge!

@sergeleger sergeleger merged commit 60631de into main Dec 23, 2025
3 checks passed
@sergeleger sergeleger deleted the dev.swl/498-web-c-in-dark-mode-the-upload-image-instruction-has-very-low-contrast branch December 23, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Web-C: in dark mode the "Upload image" instruction has very low contrast

3 participants