fix: make npx nx bundle web component automatically build first #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
Contributor
|
joanise
approved these changes
Dec 23, 2025
Member
joanise
left a comment
joanise
left a comment
There was a problem hiding this comment.
That's a great idea, thanks! We should have done this a long time ago.
sergeleger
deleted the
dev.swl/445-make-npx-nx-bundle-web-component-automatically-build-first
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Goal?
Forces a web component build when the bundle script is called, this avoids bundling a stale version of the readalong web component.
Also, since
npx nx bundle web-componentnow performs a build operation, simplified the CI scripts to avoid unnecessary builds.Fixes?
Closes #445
Feedback sought?
Priority?
Low
Tests added?
No
How to test?
Not easy to test: one approach would be to
dist/packages/web-component/directory.npx nx bundle web-componentsucceeds (while onmainit would not)Confidence?
High
Version change?
No