Fix: Unstackable item duplication bug #262
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrentDaMage
approved these changes
Jan 11, 2026
Collaborator
|
Most well-documented PR for this repo I have ever come across. Good job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixed a bug where unstackable items like doors would duplicate when picked up if the player already had one of the same type in their inventory.
Changes
When combining items into an existing slot in
Inventory::addItem(), the code was incorrectly settingcombinedItemAmount = C_MAX_INVENTORY_STACK_SIZE(64) instead ofmaxStackSizefor items with leftover count. This caused unstackable items (maxStackSize=1) to be improperly stacked to 64, with the overflow creating duplicate items.Demo (after fix)
Closes #168