Add credits screen #260
Draft
Add credits screen #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| SAFE_DELETE(m_pDarkBackground); | ||
|
|
||
| m_pDarkBackground = new WorldSelectionList(m_pMinecraft, m_width, m_height); |
Contributor
There was a problem hiding this comment.
Why are you using an entire WorldSelectionList for the sole purpose of... drawing a dark background? That seems really over-complicated.
Collaborator
There was a problem hiding this comment.
If I recall correctly, there are two functions inside either the WorldSelectionList or both of the ScrolledSelectionLists that are responsible for drawing the top and bottom bars.
Contributor
Author
There was a problem hiding this comment.
idk any other way to do it :P
…the credits screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a credits screen accessible by clicking the logo on the title screen.
For now just a simple screen with some text and a few prominent contributors names in alphabetical order, no scrolling.
Requires #259