Skip to content

Fixing bug - overflowing error strings in async jobs. #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krulis-martin merged 1 commit into from
Dec 12, 2024
Merged

Fixing bug - overflowing error strings in async jobs. #474

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions app/model/entity/AsyncJob.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,9 +211,21 @@ public function getError(): ?string
return $this->error;
}

/**
* Makes sure the error string fits the data column.
* Truncates and adds ellipsis '...' at the end if it overflows.
*/
private function sanitizeErrorLength(): void
{
if ($this->error !== null && strlen($this->error) > 250) {
$this->error = substr($this->error, 0, 250) . '...';
}
}

public function setError(?string $error)
{
$this->error = $error;
$this->sanitizeErrorLength();
}

public function appendError(string $error)
Expand All @@ -223,6 +235,7 @@ public function appendError(string $error)
} else {
$this->error .= "\n$error";
}
$this->sanitizeErrorLength();
}

/**
Expand Down