Conversation
Reviewer's GuideThis PR promotes File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
usage()the--tailbehavior is described both under the top-level usage block and again underswitchesas a launch option; consider tightening this wording to more clearly distinguish the start-command forms from the switches and avoid potential confusion about whether--tailis a subcommand or a flag. - In the README
Switchestable, the--taildescription is self-referential ("Equivalent tosigmund --tail <cmd...>"); you might rephrase this to describe what it does (e.g., "Launch and immediately stream command log output") to be consistent with the wording used elsewhere.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `usage()` the `--tail` behavior is described both under the top-level usage block and again under `switches` as a launch option; consider tightening this wording to more clearly distinguish the start-command forms from the switches and avoid potential confusion about whether `--tail` is a subcommand or a flag.
- In the README `Switches` table, the `--tail` description is self-referential ("Equivalent to `sigmund --tail <cmd...>`"); you might rephrase this to describe what it does (e.g., "Launch and immediately stream command log output") to be consistent with the wording used elsewhere.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
listaction a proper subcommand (sigmund list) while keeping-l/--listas aliases to align CLI semantics with README examples and tests.--as a separator rather than a switch.Description
listas a recognized command verb inmain()while preserving-land--listas aliases by updatingsrc/sigmund.cto dispatch on"list"(and-l/--list).usage()text insrc/sigmund.cinto sections: usage, commands, switches, and a note explaining--as an argument separator.README.mdto usesigmund listin examples and to restructure the Command Reference intoStart commands,Management commands, andSwitchesand add the--note.tests/test_sigmund.shto calllistinstead of-lso test assertions match the new preferred CLI semantics.Testing
make clean && make, which completed successfully../tests/test_sigmund.sh, and all tests passed (all test cases printedPASS).Codex Task
Summary by Sourcery
Promote
listto a first-class CLI subcommand and align help text, documentation, and tests with the new command structure.New Features:
listas a primarysigmundmanagement command while keeping-land--listas aliases.Enhancements:
--as an argument separator.Documentation:
sigmund list, introduce start vs. management command groupings, and document switches and--behavior.Tests:
sigmund listinstead of-lso they validate the new preferred CLI usage.