Skip to content

Use future instead of Thread. to preserve bindings #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devth wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use future instead of Thread. to preserve bindings #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 13 additions & 15 deletions src/irclj/core.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,21 +139,19 @@
:init-mode mode
:network host
:ready? (promise)})]
(.start
(Thread.
(fn []
(try
(connection/set-timeout irc timeout)
(connection/register-connection irc)
(loop [lines (connection/safe-line-seq in)]
(if-let [line (first lines)]
(do (process irc line)
(recur (rest lines)))
(events/fire irc :on-shutdown)))
(catch Exception e
(deliver (:ready? @irc) false) ;; unblock the promise
(events/fire irc :on-exception e)
(throw e))))))
(future
(try
(connection/set-timeout irc timeout)
(connection/register-connection irc)
(loop [lines (connection/safe-line-seq in)]
(if-let [line (first lines)]
(do (process irc line)
(recur (rest lines)))
(events/fire irc :on-shutdown)))
(catch Exception e
(deliver (:ready? @irc) false) ;; unblock the promise
(events/fire irc :on-exception e)
(throw e))))

irc))

Expand Down