Skip to content

Conversation

@agagniere
Copy link
Contributor

@agagniere agagniere commented Aug 7, 2025

  • In build.zig, specify root_module
  • Bump dependency for 0.15
  • Use the new {f} formatter syntax
  • Adapt IOs post writergate

@agagniere
Copy link
Contributor Author

Depends on rockorager/zeit#39

@agagniere
Copy link
Contributor Author

The first commit is still compatible with zig 0.14
The second breaks the API so I bumped the version

@agagniere
Copy link
Contributor Author

agagniere commented Aug 9, 2025

To review:

  • I removed the buffering in the config, because now all writers have a buffer (that can be of size 0), so the choice to bufferize or not is made outside of Axe.
  • I added a flush_each_log in the config to choose if the writers are flushed after each log.
  • Regardless of the config, stderr is buffered and flushed after each log. It might make more sense to take config into account here, which would involve adding a buffer for stderr in the axe struct

@agagniere agagniere marked this pull request as ready for review August 20, 2025 07:44
Copy link
Owner

@Ratakor Ratakor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@agagniere
Copy link
Contributor Author

OK, added a test for strftime, only checking the number of characters written, so now the relevant code is actually compiled.

@agagniere agagniere requested a review from Ratakor August 20, 2025 13:12
@agagniere
Copy link
Contributor Author

Wait I forgot to add a way to flush all writers at the end

@agagniere
Copy link
Contributor Author

OK, should be good now !
I added a public flush function, called in deinit, for users to be able to force flush any time

@agagniere agagniere requested a review from Ratakor August 21, 2025 21:16
Including the example's build.zig
Bumping zeit to get their updated build.zig as well
@agagniere agagniere force-pushed the zig-0.15 branch 2 times, most recently from 5c6a082 to e5b5566 Compare August 21, 2025 22:02
@Ratakor Ratakor merged commit ef9f954 into Ratakor:master Aug 22, 2025
4 checks passed
@Ratakor
Copy link
Owner

Ratakor commented Aug 22, 2025

Thank you!

@agagniere agagniere deleted the zig-0.15 branch August 22, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants