Skip to content

added dumbo.yml #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
TheSlopper wants to merge 5 commits into
base: main
Choose a base branch
from
Open

added dumbo.yml #64

TheSlopper wants to merge 5 commits into from

Conversation

@TheSlopper
Copy link
Contributor

@TheSlopper TheSlopper commented Feb 11, 2023

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

raylmorris
raylmorris requested changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@raylmorris raylmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix spelling to dumbo

BarberLo
BarberLo previously approved these changes Feb 18, 2023
View reviewed changes
@ChrisHirsch ChrisHirsch changed the title added dumdo.yml added dumbo.yml Feb 18, 2023
ChrisHirsch
ChrisHirsch requested changes Feb 18, 2023
View reviewed changes
BarberLo
BarberLo previously approved these changes Feb 23, 2023
View reviewed changes
Leaf-life
Leaf-life previously approved these changes Feb 23, 2023
View reviewed changes
@Leaf-life Leaf-life dismissed stale reviews from BarberLo and themself via 9c985a5 February 23, 2023 01:40
ChrisHirsch
ChrisHirsch approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@ChrisHirsch ChrisHirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

raylmorris
raylmorris reviewed Feb 23, 2023
View reviewed changes
configs/dumbo.yml
drivetrain:
required: true
type: yaml
file: "talonTankDrive.yml"
Copy link
Contributor

@raylmorris raylmorris Feb 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file doesn't exist anymore. Should be talonFXTankDrive.yml or talonSRXTankDriveSmall.yml

Copy link
Contributor

@raylmorris raylmorris Feb 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure it's FX, but not confident enough to make the change myself

Copy link
Contributor

@raylmorris raylmorris Feb 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#70 Accounts for this difference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raylmorris raylmorris raylmorris requested changes

@ChrisHirsch ChrisHirsch ChrisHirsch approved these changes

@Leaf-life Leaf-life Leaf-life approved these changes

@BarberLo BarberLo BarberLo left review comments

@tuffinmuffin tuffinmuffin Awaiting requested review from tuffinmuffin tuffinmuffin is a code owner

@jeffrey-jenkins jeffrey-jenkins Awaiting requested review from jeffrey-jenkins

@jtdurham jtdurham Awaiting requested review from jtdurham jtdurham is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

💻 programming

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@TheSlopper @ChrisHirsch @BarberLo @Leaf-life @raylmorris @ManiacMoustache