Dashboard version #136
Dashboard version #136
Conversation
ChrisHirsch
requested review from
jeffrey-jenkins,
raylmorris and
tuffinmuffin
as code owners
| # We should only need to do this once | ||
| wpilib.SmartDashboard.putString("Robot Version", self.getDeployInfo("git-hash")) | ||
| wpilib.SmartDashboard.putString("Git Branch", self.getDeployInfo("git-branch")) | ||
| wpilib.SmartDashboard.putString( |
There was a problem hiding this comment.
consider: creat a new network table for versions and config info. Seems like we should get better at organizing our data
| else: | ||
| return f"Key: {key} Not Found in JSON" | ||
| except OSError: | ||
| return "unknown" |
There was a problem hiding this comment.
always capture error and print at least summary with error (except when it's normal and you don't want it. Like files does not exist you and it's expected to be missing sometimes). But unknown errors always print at least the summary. stack is preferred but optional. future you will thank you.
robots/configBasedRobot.py
Outdated
| except OSError: | ||
| return "unknown" | ||
| except json.JSONDecodeError: | ||
| return "bad json in deploy file check for unescaped \ " |
There was a problem hiding this comment.
does decode error give any helpful tips back to location of error?
utils/configMapper.py
Outdated
|
|
||
| log = logging.getLogger("configMapper") | ||
|
|
||
|
|
There was a problem hiding this comment.
global: format only changes please revert in untouched files. if we want to update style do it on purpose I'm another Mr for style clean up. applys to other files in review also.
There was a problem hiding this comment.
this file may have other changes. If so we should talk about differing styles and auto formatters.
Types of changes
Associated Issue(s)
Issue: #110
Steps to Test
Changelog
Added Git Sha for deployed version
What?
Read from the deploy.json file (happens each deploy), parse it and then add value of git-hash to shuffleboard
Why?
The drivers want to know which version of code they are running with.